From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: "Sylwester Nawrocki" <s.nawrocki@samsung.com>,
kernel-janitors@vger.kernel.org,
"Fabien Dessenne" <fabien.dessenne@st.com>,
linux-samsung-soc@vger.kernel.org,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Kamil Debski" <kamil@wypas.org>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Guennadi Liakhovetski" <g.liakhovetski@gmx.de>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
"Hyun Kwon" <hyun.kwon@xilinx.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Andrzej Pietrasiewicz" <andrzej.p@samsung.com>,
"Jacek Anaszewski" <j.anaszewski@samsung.com>,
"Mikhail Ulyanov" <mikhail.ulyanov@cogentembedded.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] [media] platform: constify vb2_ops structures
Date: Fri, 09 Sep 2016 11:42:19 +0300 [thread overview]
Message-ID: <1520635.43zSurJaks@avalon> (raw)
In-Reply-To: <1473379150-17315-1-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
Thank you for the patch.
On Friday 09 Sep 2016 01:59:10 Julia Lawall wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure. That field is declared const, so vb2_ops structures
> that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct vb2_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct vb2_queue e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct vb2_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct vb2_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
For the drivers below,
> drivers/media/platform/m2m-deinterlace.c | 2 +-
> drivers/media/platform/rcar-vin/rcar-dma.c | 2 +-
> drivers/media/platform/rcar_jpu.c | 2 +-
> drivers/media/platform/sh_vou.c | 2 +-
> drivers/media/platform/soc_camera/atmel-isi.c | 2 +-
> drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c | 2 +-
> drivers/media/platform/vim2m.c | 2 +-
> drivers/media/platform/xilinx/xilinx-dma.c | 2 +-
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
For
> drivers/media/platform/soc_camera/rcar_vin.c | 2 +-
you can also add my
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
tag, but the driver will be scheduled for removal very soon.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-09-09 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 23:59 [PATCH] [media] platform: constify vb2_ops structures Julia Lawall
2016-09-09 8:42 ` Laurent Pinchart [this message]
2016-09-09 8:53 ` Fabien DESSENNE
2016-09-09 9:48 ` Jacek Anaszewski
2016-09-09 16:03 ` Benoit Parrot
2017-01-21 9:29 [PATCH] media: " Bhumika Goyal
2017-01-25 10:08 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520635.43zSurJaks@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=Julia.Lawall@lip6.fr \
--cc=a.hajda@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=bparrot@ti.com \
--cc=fabien.dessenne@st.com \
--cc=g.liakhovetski@gmx.de \
--cc=hyun.kwon@xilinx.com \
--cc=j.anaszewski@samsung.com \
--cc=kamil@wypas.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mikhail.ulyanov@cogentembedded.com \
--cc=s.nawrocki@samsung.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).