From: Ivan Gorinov <ivan.gorinov@intel.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Frank Rowand <frowand.list@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v5 1/2] of: Documentation: Specify local APIC ID in "reg"
Date: Tue, 13 Mar 2018 10:50:14 -0700 [thread overview]
Message-ID: <1520963414.38672.31.camel@intel.com> (raw)
In-Reply-To: <20180313110153.vdtgljcvsbwiixwx@lakrids.cambridge.arm.com>
On Tue, 2018-03-13 at 11:01 +0000, Mark Rutland wrote:
> > + cpu@1 {
> > + device_type = "cpu";
> > + compatible = "intel,ce4100";
> > + reg = <0x02>;
> > + };
> The unit-address (the bit after the '@' in the node name) should match
> the reg, so this node should be named cpu@2.
OK
> > -The reg property describes the CPU number. The lapic property points to
> > -the local APIC timer.
> Why was the lapic phandle removed?
The "lapic" node may not be required.
Local APIC is an essential part of every logical CPU described by a "cpu"
node, with registers accessed as memory-mapped I/O (except for x2APIC mode).
Current implementation of local APIC kernel driver requires base address to
be the same on all CPUs, default 0xfee00000. If the base address is changed
by firmware, one optional node can describe new address for all CPUs.
next prev parent reply other threads:[~2018-03-13 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 22:21 [PATCH v5 0/2] x86/devicetree: Enable multiprocessing Ivan Gorinov
2018-03-12 22:21 ` [PATCH v5 1/2] of: Documentation: Specify local APIC ID in "reg" Ivan Gorinov
2018-03-13 11:01 ` Mark Rutland
2018-03-13 17:50 ` Ivan Gorinov [this message]
2018-03-12 22:22 ` [PATCH v5 2/2] x86/devicetree: Use CPU description from Device Tree Ivan Gorinov
2018-03-13 11:03 ` Mark Rutland
2018-03-14 12:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520963414.38672.31.camel@intel.com \
--to=ivan.gorinov@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).