From: Stephen Boyd <sboyd@kernel.org>
To: Jolly Shah <jolly.shah@xilinx.com>,
linux-clk@vger.kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, mturquette@baylibre.com,
robh+dt@kernel.org, sboyd@codeaurora.org
Cc: rajanv@xilinx.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Jolly Shah <jolly.shah@xilinx.com>,
Jolly Shah <jollys@xilinx.com>, Tejas Patel <tejasp@xilinx.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCH 1/3] drivers: clk: Add clk_get_children support
Date: Mon, 19 Mar 2018 11:21:55 -0700 [thread overview]
Message-ID: <152148371542.242365.18433130635050412528@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1519856861-31384-2-git-send-email-jollys@xilinx.com>
Quoting Jolly Shah (2018-02-28 14:27:39)
> From: Jolly Shah <jolly.shah@xilinx.com>
>
> This API helps to determine the users for any clock.
Ok, but why do you need it?
>
> Signed-off-by: Jolly Shah <jollys@xilinx.com>
> Signed-off-by: Tejas Patel <tejasp@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> drivers/clk/clk.c | 28 ++++++++++++++++++++++++++++
> include/linux/clk-provider.h | 1 +
> 2 files changed, 29 insertions(+)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 0f686a9..947a18b 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -274,6 +274,34 @@ struct clk_hw *clk_hw_get_parent(const struct clk_hw *hw)
> }
> EXPORT_SYMBOL_GPL(clk_hw_get_parent);
>
> +static unsigned int sibling;
Looks very thread unsafe!
> +
> +static void clk_show_subtree(struct clk_core *c,
> + int level)
> +{
> + struct clk_core *child;
> +
> + if (!c)
> + return;
> +
> + if (level == 1)
> + sibling++;
> +
> + hlist_for_each_entry(child, &c->children, child_node)
> + clk_show_subtree(child, level + 1);
> +}
> +
> +unsigned int clk_get_children(char *name)
> +{
> + struct clk_core *core;
> + struct clk *pclk = __clk_lookup(name);
> +
> + sibling = 0;
> + core = pclk->core;
> + clk_show_subtree(core, 0);
> + return sibling;
> +}
> +
> static struct clk_core *__clk_lookup_subtree(const char *name,
> struct clk_core *core)
> {
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index f711be6..e94dfb2 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -745,6 +745,7 @@ unsigned int __clk_get_enable_count(struct clk *clk);
> unsigned long clk_hw_get_rate(const struct clk_hw *hw);
> unsigned long __clk_get_flags(struct clk *clk);
> unsigned long clk_hw_get_flags(const struct clk_hw *hw);
> +unsigned int clk_get_children(char *name);
And uses a string lookup instead of having the clk_hw pointer in hand.
No thanks.
next prev parent reply other threads:[~2018-03-19 19:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 22:27 [PATCH 0/3] drivers: clk: Add ZynqMp clock driver support Jolly Shah
2018-02-28 22:27 ` [PATCH 1/3] drivers: clk: Add clk_get_children support Jolly Shah
2018-03-19 18:21 ` Stephen Boyd [this message]
2018-03-20 19:29 ` Jolly Shah
2018-02-28 22:27 ` [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock driver Jolly Shah
2018-03-06 1:45 ` Rob Herring
2018-03-07 22:47 ` Jolly Shah
2018-03-08 1:20 ` Rob Herring
2018-03-13 18:39 ` Jolly Shah
2018-03-19 18:23 ` Stephen Boyd
2018-03-20 19:15 ` Jolly Shah
2018-02-28 22:27 ` [PATCH 3/3] drivers: clk: Add " Jolly Shah
2018-03-03 3:32 ` kbuild test robot
2018-03-05 10:37 ` Sudeep Holla
2018-03-19 20:09 ` Stephen Boyd
2018-03-21 19:59 ` Jolly Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152148371542.242365.18433130635050412528@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jolly.shah@xilinx.com \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=tejasp@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).