From: Stephen Boyd <swboyd@chromium.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Timur Tabi <timur@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
linux-gpio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
Date: Wed, 21 Mar 2018 13:17:49 -0700 [thread overview]
Message-ID: <152166346979.154352.7302935269984897659@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20180321165848.89751-4-swboyd@chromium.org>
Quoting Stephen Boyd (2018-03-21 09:58:48)
> + ret = device_property_read_u16_array(pctrl->dev, "gpios", NULL, 0);
> + if (ret > 0 && ret < max_gpios) {
> + u16 *tmp;
> +
> + len = ret;
> + tmp = kmalloc_array(len, sizeof(tmp[0]), GFP_KERNEL);
> + if (!tmp)
> + return -ENOMEM;
> +
> + ret = device_property_read_u16_array(pctrl->dev, "gpios", tmp,
> + len);
> + if (ret < 0) {
> + dev_err(pctrl->dev, "could not read list of GPIOs\n");
> + kfree(tmp);
> + return ret;
> + }
> +
> + bitmap_zero(chip->valid_mask, max_gpios);
> + for (i = 0; i < len; i++)
> + set_bit(tmp[i], chip->valid_mask);
This leaks tmp too.. I'll fix that in v4 and resend tomorrow if there
aren't more comments.
next prev parent reply other threads:[~2018-03-21 20:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:58 [PATCH v3 0/3] Support qcom pinctrl protected pins Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 1/3] dt-bindings: gpio: Add a gpio-reserved-ranges property Stephen Boyd
2018-03-21 16:58 ` [PATCH v3 2/3] gpiolib: Support 'gpio-reserved-ranges' property Stephen Boyd
2018-03-21 17:59 ` Andy Shevchenko
2018-03-21 18:02 ` Andy Shevchenko
2018-03-21 19:59 ` Stephen Boyd
2018-03-21 20:31 ` Andy Shevchenko
2018-03-27 13:24 ` Linus Walleij
2018-03-21 16:58 ` [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested Stephen Boyd
2018-03-21 18:07 ` Andy Shevchenko
2018-03-21 20:04 ` Stephen Boyd
2018-03-21 20:30 ` Andy Shevchenko
2018-03-21 20:17 ` Stephen Boyd [this message]
2018-03-23 0:16 ` Timur Tabi
2018-03-23 0:23 ` Timur Tabi
2018-03-23 0:59 ` Timur Tabi
2018-03-23 11:34 ` Andy Shevchenko
2018-03-23 14:03 ` Timur Tabi
2018-03-23 11:36 ` Andy Shevchenko
2018-03-23 16:21 ` Stephen Boyd
2018-03-23 16:25 ` Timur Tabi
2018-03-23 16:31 ` Andy Shevchenko
2018-03-23 16:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152166346979.154352.7302935269984897659@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).