From: Sean Wang <sean.wang@mediatek.com>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>
Cc: <robh+dt@kernel.org>, <linus.walleij@linaro.org>,
<mark.rutland@arm.com>, <matthias.bgg@gmail.com>,
<devicetree@vger.kernel.org>, <hongkun.cao@mediatek.com>,
<srv_heupstream@mediatek.com>, <linux-gpio@vger.kernel.org>,
<biao.huang@mediatek.com>, <erin.lo@mediatek.com>,
<liguo.zhang@mediatek.com>, <linux-kernel@vger.kernel.org>,
<hongzhou.yang@mediatek.com>,
<linux-mediatek@lists.infradead.org>, <yingjoe.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 4/5] pintcrl: support bias-disable of generic and special pins simultaneously
Date: Fri, 23 Mar 2018 17:44:22 +0800 [thread overview]
Message-ID: <1521798262.28226.12.camel@mtkswgap22> (raw)
In-Reply-To: <1521687523-1604-5-git-send-email-zhiyong.tao@mediatek.com>
On Thu, 2018-03-22 at 10:58 +0800, Zhiyong Tao wrote:
> For generic pins, parameter "arg" is 0 or 1.
> For special pins, bias-disable is set by R0R1,
> so we need transmited "00" to set bias-disable
> When we set "bias-disable" as high-z property,
> the parameter should be "MTK_PUPD_SET_R1R0_00".
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 3cf384f..f991ff3 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -293,7 +293,7 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl,
> unsigned int pin, bool enable, bool isup, unsigned int arg)
> {
> unsigned int bit;
> - unsigned int reg_pullen, reg_pullsel;
> + unsigned int reg_pullen, reg_pullsel, r1r0;
> int ret;
>
> /* Some pins' pull setting are very different,
> @@ -301,8 +301,12 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl,
> * resistor bit, so we need this special handle.
> */
> if (pctl->devdata->spec_pull_set) {
> + /* For special pins, bias-disable is set by R1R0,
> + * the parameter should be "MTK_PUPD_SET_R1R0_00".
> + */
> + r1r0 = enable ? arg : MTK_PUPD_SET_R1R0_00;
> ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin),
> - pin, pctl->devdata->port_align, isup, arg);
> + pin, pctl->devdata->port_align, isup, r1r0);
> if (!ret)
> return 0;
> }
Reviewed-by: Sean Wang <sean.wang@mediatek.com>
next prev parent reply other threads:[~2018-03-23 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 2:58 [PATCH v4 0/5] PINCTRL: Mediatek pinctrl driver for mt2712 Zhiyong Tao
2018-03-22 2:58 ` [PATCH v4 1/5] arm64: dts: mt2712: add pintcrl file Zhiyong Tao
2018-04-17 14:31 ` Matthias Brugger
2018-03-22 2:58 ` [PATCH v4 2/5] arm64: dts: mt2712: add pintcrl device node Zhiyong Tao
2018-04-17 14:31 ` Matthias Brugger
2018-03-22 2:58 ` [PATCH v4 3/5] pinctrl: add mt2712 pinctrl driver Zhiyong Tao
2018-03-24 6:58 ` Sean Wang
2018-03-26 8:56 ` Linus Walleij
2018-03-22 2:58 ` [PATCH v4 4/5] pintcrl: support bias-disable of generic and special pins simultaneously Zhiyong Tao
2018-03-23 9:44 ` Sean Wang [this message]
2018-03-26 8:57 ` Linus Walleij
2018-03-22 2:58 ` [PATCH v4 5/5] pinctrl: fix check warnings Zhiyong Tao
2018-03-26 8:59 ` Linus Walleij
2018-03-23 2:58 ` [PATCH v4 0/5] PINCTRL: Mediatek pinctrl driver for mt2712 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521798262.28226.12.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=erin.lo@mediatek.com \
--cc=hongkun.cao@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).