From: Sean Wang <sean.wang@mediatek.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <sre@kernel.org>,
<lee.jones@linaro.org>, <a.zummo@towertech.it>,
<eddie.huang@mediatek.com>, <devicetree@vger.kernel.org>,
<linux-rtc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 06/16] rtc: mediatek: remove unnecessary parentheses
Date: Sat, 24 Mar 2018 15:14:12 +0800 [thread overview]
Message-ID: <1521875652.28226.29.camel@mtkswgap22> (raw)
In-Reply-To: <20180323102123.GG3417@piout.net>
On Fri, 2018-03-23 at 11:21 +0100, Alexandre Belloni wrote:
> On 23/03/2018 at 17:15:03 +0800, sean.wang@mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> >
> > Remove unnecessary parentheses due to explicit C operator precedence.
> >
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > ---
> > drivers/rtc/rtc-mt6397.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> > index 0df7ccd..4411c08 100644
> > --- a/drivers/rtc/rtc-mt6397.c
> > +++ b/drivers/rtc/rtc-mt6397.c
> > @@ -106,7 +106,7 @@ static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void *data)
> > int ret;
> >
> > ret = regmap_read(rtc->regmap, rtc->addr_base + RTC_IRQ_STA, &irqsta);
> > - if ((ret >= 0) && (irqsta & RTC_IRQ_STA_AL)) {
> > + if (ret >= 0 && irqsta & RTC_IRQ_STA_AL) {
>
> I don't think this makes the code particularly clearer.
>
But it is still a one of check items in checkpatch
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ret >= 0'
#126: FILE: drivers/rtc/rtc-xxx.c:109:
+ if ((ret >= 0) && (irqsta & RTC_IRQ_STA_AL)) {
or we still want to keep it in parentheses around here?
> > rtc_update_irq(rtc->rtc_dev, 1, RTC_IRQF | RTC_AF);
> > irqen = irqsta & ~RTC_IRQ_EN_AL;
> > mutex_lock(&rtc->lock);
> > --
> > 2.7.4
> >
>
next prev parent reply other threads:[~2018-03-24 7:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 9:14 [PATCH v1 00/16] Add support to MT6323 RTC and its power device sean.wang
2018-03-23 9:14 ` [PATCH v1 01/16] dt-bindings: power: reset: mediatek: add bindings for " sean.wang
2018-03-26 22:24 ` Rob Herring
2018-03-27 3:21 ` Sean Wang
2018-03-23 9:14 ` [PATCH v1 02/16] dt-bindings: rtc: mediatek: add bindings for PMIC RTC sean.wang
2018-03-23 9:41 ` Alexandre Belloni
2018-03-23 10:15 ` Alexandre Belloni
2018-03-24 19:36 ` Sean Wang
2018-03-27 15:18 ` Alexandre Belloni
2018-03-28 3:53 ` Sean Wang
2018-03-28 9:19 ` Alexandre Belloni
2018-03-23 9:15 ` [PATCH v1 03/16] dt-bindings: mfd: mediatek: add a description for MT6323 RTC sean.wang
2018-03-26 22:24 ` Rob Herring
2018-03-28 11:13 ` Lee Jones
2018-03-23 9:15 ` [PATCH v1 04/16] mfd: mt6397: add MT6323 RTC support into MT6397 driver sean.wang
2018-03-28 11:15 ` Lee Jones
2018-03-23 9:15 ` [PATCH v1 05/16] rtc: mediatek: add MT6323 support to RTC driver sean.wang
2018-03-23 10:01 ` Alexandre Belloni
2018-03-24 7:06 ` Sean Wang
2018-03-23 9:15 ` [PATCH v1 06/16] rtc: mediatek: remove unnecessary parentheses sean.wang
2018-03-23 10:21 ` Alexandre Belloni
2018-03-24 7:14 ` Sean Wang [this message]
2018-03-24 18:53 ` Alexandre Belloni
2018-03-24 19:21 ` Sean Wang
2018-03-23 9:15 ` [PATCH v1 07/16] rtc: mediatek: replace a poll with regmap_read_poll_timeout sean.wang
2018-03-23 9:15 ` [PATCH v1 08/16] rtc: mediatek: remove unnecessary irq_dispose_mapping sean.wang
2018-03-23 10:38 ` Alexandre Belloni
2018-03-26 2:22 ` Sean Wang
2018-03-23 9:15 ` [PATCH v1 09/16] rtc: mediatek: convert to use device managed functions sean.wang
2018-03-23 10:50 ` Alexandre Belloni
2018-03-26 4:07 ` Sean Wang
2018-03-27 15:07 ` Alexandre Belloni
2018-03-23 9:15 ` [PATCH v1 10/16] rtc: mediatek: add devm_of_platform_populate sean.wang
2018-03-23 9:15 ` [PATCH v1 11/16] rtc: mediatek: move the declaration into a globally visible header file sean.wang
2018-03-23 9:57 ` Alexandre Belloni
2018-03-24 7:31 ` Sean Wang
2018-03-24 18:54 ` Alexandre Belloni
2018-03-24 20:00 ` Fabio Estevam
2018-03-25 3:13 ` Sean Wang
2018-03-23 9:15 ` [PATCH v1 12/16] rtc: mediatek: cleanup header files to include sean.wang
2018-03-25 4:17 ` kbuild test robot
2018-03-25 5:21 ` kbuild test robot
2018-03-23 9:15 ` [PATCH v1 13/16] rtc: mediatek: update license converting to using SPDX identifiers sean.wang
2018-03-23 9:15 ` [PATCH v1 14/16] power: reset: mediatek: add a power-off driver using PMIC RTC device sean.wang
2018-03-23 9:15 ` [PATCH v1 15/16] MAINTAINERS: update entry for ARM/Mediatek RTC DRIVER sean.wang
2018-03-23 9:15 ` [PATCH v1 16/16] MAINTAINERS: add an entry for MediaTek board level shutdown driver sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521875652.28226.29.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).