From: Stefan Popa <stefan.popa@analog.com>
To: <jic23@kernel.org>, <Michael.Hennerich@analog.com>, <lars@metafoo.de>
Cc: <knaack.h@gmx.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stefan.popa@analog.com>
Subject: [PATCH v2 3/6] iio:dac:ad5686: Add support for AD5685R
Date: Tue, 10 Apr 2018 18:57:29 +0300 [thread overview]
Message-ID: <1523375849-29508-1-git-send-email-stefan.popa@analog.com> (raw)
In-Reply-To: <1522418118-11810-2-git-send-email-stefan.popa@analog.com>
This driver acctually supports the AD5685R device and NOT the AD5685, which
does not exist.
More information can be found in the datasheet:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5686_5684.pdf
Signed-off-by: Stefan Popa <stefan.popa@analog.com>
---
Changes in v2:
- Refactored the patch to add support for new parts
drivers/iio/dac/ad5686.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index 4d1ae3d..7353c03 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -89,7 +89,7 @@ struct ad5686_state {
enum ad5686_supported_device_ids {
ID_AD5684,
- ID_AD5685,
+ ID_AD5685R,
ID_AD5686,
};
static int ad5686_spi_write(struct ad5686_state *st,
@@ -304,7 +304,7 @@ static const struct ad5686_chip_info ad5686_chip_info_tbl[] = {
.num_channels = 4,
.int_vref_mv = 2500,
},
- [ID_AD5685] = {
+ [ID_AD5685R] = {
.channels = ad5685r_channels,
.int_vref_mv = 2500,
.num_channels = 4,
@@ -393,7 +393,7 @@ static int ad5686_remove(struct spi_device *spi)
static const struct spi_device_id ad5686_id[] = {
{"ad5684", ID_AD5684},
- {"ad5685", ID_AD5685},
+ {"ad5685r", ID_AD5685R},
{"ad5686", ID_AD5686},
{}
};
--
2.7.4
next prev parent reply other threads:[~2018-04-10 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 13:55 [PATCH 1/3] iio:dac:ad5686: Style fixes no functional changes Stefan Popa
2018-03-30 13:55 ` [PATCH 2/3] iio:dac:ad5686: Add AD5672R/AD5676/AD5676R/AD5684R/AD5685R/AD5686R support Stefan Popa
2018-04-06 15:19 ` Jonathan Cameron
2018-04-10 15:57 ` [PATCH v2 2/6] iio:dac:ad5686: Add support for various number of channels Stefan Popa
2018-04-11 11:52 ` [PATCH v3 3/7] " Stefan Popa
2018-04-15 18:16 ` Jonathan Cameron
2018-04-10 15:57 ` Stefan Popa [this message]
2018-04-11 11:52 ` [PATCH v3 4/7] iio:dac:ad5686: Add support for AD5685R Stefan Popa
2018-04-15 18:20 ` Jonathan Cameron
2018-04-10 15:57 ` [PATCH v2 4/6] iio:dac:ad5686: Add AD5672R/76/76R/84R/86R support Stefan Popa
2018-04-11 11:53 ` [PATCH v3 5/7] " Stefan Popa
2018-04-15 18:23 ` Jonathan Cameron
2018-04-10 15:56 ` [PATCH v2 1/6] iio:dac:ad5686: Style fixes no functional changes Stefan Popa
2018-04-11 11:51 ` [PATCH v3 1/7] " Stefan Popa
2018-04-15 18:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523375849-29508-1-git-send-email-stefan.popa@analog.com \
--to=stefan.popa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).