From: Luca Ceresoli <luca@lucaceresoli.net>
To: linux-media@vger.kernel.org
Cc: Luca Ceresoli <luca@lucaceresoli.net>,
Leon Luo <leonl@leopardimaging.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 04/13] imx274: remove unused data from struct imx274_frmfmt
Date: Thu, 12 Apr 2018 18:51:09 +0200 [thread overview]
Message-ID: <1523551878-15754-5-git-send-email-luca@lucaceresoli.net> (raw)
In-Reply-To: <1523551878-15754-1-git-send-email-luca@lucaceresoli.net>
struct imx274_frmfmt is instantiated only in the imx274_formats[]
array, where imx274_formats[N].mode always equals N (via enum
imx274_mode). So .mode carries no information, and unsurprisingly it
is never used.
mbus_code is never used because the 12 bit modes are not implemented.
The colorspace member is also never used, which is normal since the
imx274 sensor can output only one colorspace.
Let's get rid of all of them.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index c5d00ade4d64..9203d377cfe2 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -156,10 +156,7 @@ enum imx274_mode {
* imx274 format related structure
*/
struct imx274_frmfmt {
- u32 mbus_code;
- enum v4l2_colorspace colorspace;
struct v4l2_frmsize_discrete size;
- enum imx274_mode mode;
};
/*
@@ -501,12 +498,9 @@ static const struct reg_8 *mode_table[] = {
* imx274 format related structure
*/
static const struct imx274_frmfmt imx274_formats[] = {
- {MEDIA_BUS_FMT_SRGGB10_1X10, V4L2_COLORSPACE_SRGB, {3840, 2160},
- IMX274_MODE_3840X2160},
- {MEDIA_BUS_FMT_SRGGB10_1X10, V4L2_COLORSPACE_SRGB, {1920, 1080},
- IMX274_MODE_1920X1080},
- {MEDIA_BUS_FMT_SRGGB10_1X10, V4L2_COLORSPACE_SRGB, {1280, 720},
- IMX274_MODE_1280X720},
+ { {3840, 2160} },
+ { {1920, 1080} },
+ { {1280, 720} },
};
/*
@@ -890,9 +884,8 @@ static int imx274_set_fmt(struct v4l2_subdev *sd,
int index;
dev_dbg(&client->dev,
- "%s: width = %d height = %d code = %d mbus_code = %d\n",
- __func__, fmt->width, fmt->height, fmt->code,
- imx274_formats[imx274->mode_index].mbus_code);
+ "%s: width = %d height = %d code = %d\n",
+ __func__, fmt->width, fmt->height, fmt->code);
mutex_lock(&imx274->lock);
--
2.7.4
next prev parent reply other threads:[~2018-04-12 16:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 16:51 [PATCH 00/13] imx274: add cropping and misc improvements Luca Ceresoli
2018-04-12 16:51 ` [PATCH 01/13] imx274: document reset delays more clearly Luca Ceresoli
2018-04-12 16:51 ` [PATCH 02/13] imx274: fix typo in comment Luca Ceresoli
2018-04-12 16:51 ` [PATCH 03/13] imx274: slightly simplify code Luca Ceresoli
2018-04-12 16:51 ` Luca Ceresoli [this message]
2018-04-12 16:51 ` [PATCH 05/13] imx274: rename and reorder register address definitions Luca Ceresoli
2018-04-12 16:51 ` [PATCH 06/13] imx274: remove non-indexed pointers from mode_table Luca Ceresoli
2018-04-12 16:51 ` [PATCH 07/13] imx274: initialize format before v4l2 controls Luca Ceresoli
2018-04-12 16:51 ` [PATCH 08/13] imx274: consolidate per-mode data in imx274_frmfmt Luca Ceresoli
2018-04-12 16:51 ` [PATCH 09/13] imx274: get rid of mode_index Luca Ceresoli
2018-04-13 17:33 ` kbuild test robot
2018-04-18 20:38 ` kbuild test robot
2018-04-12 16:51 ` [PATCH 10/13] imx274: actually use IMX274_DEFAULT_MODE Luca Ceresoli
2018-04-12 16:51 ` [PATCH 11/13] imx274: simplify imx274_write_table() Luca Ceresoli
2018-04-12 16:51 ` [PATCH 12/13] imx274: add helper function to fill a reg_8 table chunk Luca Ceresoli
2018-04-12 16:51 ` [PATCH 13/13] imx274: add SELECTION support for cropping Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523551878-15754-5-git-send-email-luca@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=leonl@leopardimaging.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).