On Mon, 2018-04-16 at 16:07 +0000, Mario.Limonciello@dell.com wrote:
> Hi Dennis,
> 
> > -----Original Message-----
> > From: Dennis Gilmore [mailto:dgilmore@redhat.com]
> > Sent: Friday, April 13, 2018 9:03 PM
> > To: linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org
> > Cc: Limonciello, Mario
> > Subject: issues with suspend on Dell XPS 13 2-in-1
> > 
> > Hi All,
> > 
> > I have a Dell XPS 13 2-in-1 (9365) that when I supend gets warm and
> > has
> > much shorter than expected battery life, it is about the same as if
> > the
> > laptop just runs. I am currently running Fedora 28 with 4.16.2
> > kernel.
> > 
> 
> Since battery consumption is quite relative I think It would be good
> if
> you can make a comparable benchmark as this is further discussed.
> Eg fully charge your notebook, pull the plug, suspend it at 100% and
> check the power left after some repeatable amount of time.
> 
> > My laptop has NVMe for storage and is configured for AHCI mode in
> > the
> > bios.
> > 
> > powertop by default shows
> > > > Bad           VM writeback timeout
> > 
> >    Bad           NMI watchdog should be turned off
> >    Bad           Autosuspend for unknown USB device 1-7 (138a:0091)
> >    Bad           Runtime PM for I2C Adapter i2c-0 (i915 gmbus dpc)
> >    Bad           Runtime PM for I2C Adapter i2c-1 (i915 gmbus dpb)
> >    Bad           Runtime PM for I2C Adapter i2c-2 (i915 gmbus dpd)
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Wireless
> > 8265 / 8275
> >    Bad           Runtime PM for PCI Device Intel Corporation Device
> > 590c
> >    Bad           Runtime PM for PCI Device Realtek Semiconductor
> > Co.,
> > Ltd. RTS525A PCI Express Card Reader
> >    Bad           Runtime PM for PCI Device Intel Corporation Device
> > 9d3d
> >    Bad           Runtime PM for PCI Device Sandisk Corp WD Black
> > NVMe
> > SSD
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP PCI Express Root Port #9
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP Thermal subsystem
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP USB 3.0 xHCI Controller
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP PMC
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP HD Audio
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP PCI Express Root Port #1
> >    Bad           Runtime PM for PCI Device Intel Corporation Device
> > 9d4b
> >    Bad           Runtime PM for PCI Device Intel Corporation Xeon
> > E3-
> > 1200 v5/E3-1500 v5/6th Gen Core Processor Thermal Subsystem
> >    Bad           Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP Integrated Sensor Hub
> >    Bad           Runtime PM for PCI Device Intel Corporation Device
> > 591e
> 
> After you've adjusted all of these in powertop, have you compared
> your performance of the battery over sleep (and actually over runtime
> usage really too)?
> 
> They should help to allow the CPU to get into deeper states.
> 
> After you've made that change you should also see on the "Idle Stats"
> page that your CPU is spending more time in the lower C states
> (hopefully
> more in C9/10).
> 
> Srinivas,
> 
> Do you know why Runtime PM is defaulting to disabled for all of these
> devices?  Is that a default kernel policy problem or a distro policy
> problem?
This is default kernel policy.
I suggest run
#turbostat
then suspend and wake
when wake up let the turbostat collect data for next sampling interval.
We have to see what are PkgC% residencies are?

Thanks,
Srinivas

> 
> 
> >    Good          Bluetooth device interface status
> >    Good          Enable Audio codec power management
> >    Good          Runtime PM for I2C Adapter i2c-8 (Synopsys
> > DesignWare
> > I2C adapter)
> >    Good          Autosuspend for USB device Integrated_Webcam_HD
> > [CNFGE16N092020028362]
> >    Good          Autosuspend for USB device xHCI Host Controller
> > [usb1]
> >    Good          Autosuspend for USB device xHCI Host Controller
> > [usb2]
> >    Good          Runtime PM for I2C Adapter i2c-7 (SMBus I801
> > adapter
> > at efa0)
> >    Good          Autosuspend for unknown USB device 1-2 (8087:0a2b)
> >    Good          Runtime PM for I2C Adapter i2c-6 (Synopsys
> > DesignWare
> > I2C adapter)
> >    Good          I2C Device i2c-DLL077A:01 has no runtime power
> > management
> >    Good          I2C Device i2c-WCOM482F:00 has no runtime power
> > management
> >    Good          Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP PCI Express Root Port #10
> >    Good          Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP CSME HECI #1
> >    Good          Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP Serial IO I2C Controller #1
> >    Good          Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP SMBus
> >    Good          Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP PCI Express Root Port #5
> >    Good          Runtime PM for PCI Device Intel Corporation
> > Sunrise
> > Point-LP Serial IO I2C Controller #0
> >    Good          Wake-on-lan status for device virbr0-nic
> >    Good          Wake-on-lan status for device virbr0
> >    Good          Wake-on-lan status for device wlp60s0
> > 
> > Regards
> > 
> > Dennis