From: Johannes Berg <johannes@sipsolutions.net>
To: Greg KH <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
syzbot <syzbot+df47f81c226b31d89fb1@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tj@kernel.org
Subject: Re: WARNING in kernfs_add_one
Date: Mon, 07 May 2018 10:43:09 +0200 [thread overview]
Message-ID: <1525682589.6049.4.camel@sipsolutions.net> (raw)
In-Reply-To: <20180505220721.GA10829@kroah.com> (sfid-20180506_000758_042156_C31EA22A)
On Sat, 2018-05-05 at 15:07 -0700, Greg KH wrote:
> > > > syzbot found the following crash on:
Maybe it should learn to differentiate warnings, if it's going to set
panic_on_warn :-)
I get why, but still, at least differentiating in the emails wouldn't be
bad.
> > > > kernfs: ns required in 'ieee80211' for 'phy3'
Huh. What does that even mean?
> > > > RIP: 0010:kernfs_add_one+0x406/0x4d0 fs/kernfs/dir.c:758
> > > > RSP: 0018:ffff8801ca9eece0 EFLAGS: 00010286
> > > > RAX: 000000000000002d RBX: ffffffff87d5cee0 RCX: ffffffff8160ba7d
> > > > RDX: 0000000000000000 RSI: ffffffff81610731 RDI: ffff8801ca9ee840
> > > > RBP: ffff8801ca9eed20 R08: ffff8801d9538500 R09: 0000000000000006
> > > > R10: ffff8801d9538500 R11: 0000000000000000 R12: ffff8801ad1cb6c0
> > > > R13: ffffffff885da640 R14: 0000000000000020 R15: 0000000000000000
> > > > kernfs_create_link+0x112/0x180 fs/kernfs/symlink.c:41
> > > > sysfs_do_create_link_sd.isra.2+0x90/0x130 fs/sysfs/symlink.c:43
> > > > sysfs_do_create_link fs/sysfs/symlink.c:79 [inline]
> > > > sysfs_create_link+0x65/0xc0 fs/sysfs/symlink.c:91
> > > > device_add_class_symlinks drivers/base/core.c:1612 [inline]
> > > > device_add+0x7a0/0x16d0 drivers/base/core.c:1810
> > > > wiphy_register+0x178a/0x2430 net/wireless/core.c:806
> > > > ieee80211_register_hw+0x13cd/0x35d0 net/mac80211/main.c:1047
> > > > mac80211_hwsim_new_radio+0x1d9b/0x3410
> > > > drivers/net/wireless/mac80211_hwsim.c:2772
> > > > hwsim_new_radio_nl+0x7a7/0xa60 drivers/net/wireless/mac80211_hwsim.c:3246
> > > > genl_family_rcv_msg+0x889/0x1120 net/netlink/genetlink.c:599
Basically we're creating a new virtual radio, which in turn creates a
new device, which we have to register.
Something is going on with the context here that makes sysfs unhappy,
but TBH I have no idea what.
johannes
next prev parent reply other threads:[~2018-05-07 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 15:47 WARNING in kernfs_add_one syzbot
2018-05-05 16:40 ` Greg KH
2018-05-05 17:43 ` Eric Dumazet
2018-05-05 22:07 ` Greg KH
2018-05-07 8:43 ` Johannes Berg [this message]
2018-05-07 9:33 ` Dmitry Vyukov
2018-05-07 9:53 ` Johannes Berg
2018-05-07 10:10 ` [PATCH] driver core: Don't ignore class_dir_create_and_add() failure Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525682589.6049.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+df47f81c226b31d89fb1@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).