From: 宋金时 <songjinshi@xiaomi.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"maco@android.com" <maco@android.com>,
"tkjos@google.com" <tkjos@google.com>,
"arve@android.com" <arve@android.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] ANDROID: binder: correct the cmd print for BINDER_WORK_RETURN_ERROR
Date: Wed, 9 May 2018 07:31:29 +0000 [thread overview]
Message-ID: <1525851089096.52313@xiaomi.com> (raw)
In case of the BINDER_WORK_RETURN_ERROR the cmd is no assignment,
so it's value will be old value or dirty value, before modifying
e->cmd, assign the value of the e->cmd to cmd to ensure the correct
print of binder_stat_br.
Signed-off-by: songjinshi <songjinshi@xiaomi.com>
---
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 4ffc84d..acd7d44a 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -4086,6 +4086,7 @@
struct binder_error *e = container_of(
w, struct binder_error, work);
+ cmd = e->cmd;
WARN_ON(e->cmd == BR_OK);
binder_inner_proc_unlock(proc);
if (put_user(e->cmd, (uint32_t __user *)ptr))
next reply other threads:[~2018-05-09 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 7:31 宋金时 [this message]
2018-05-09 18:08 ` [PATCH] ANDROID: binder: correct the cmd print for BINDER_WORK_RETURN_ERROR Todd Kjos
2018-05-10 2:41 ` 答复: " 宋金时
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525851089096.52313@xiaomi.com \
--to=songjinshi@xiaomi.com \
--cc=arve@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).