From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <thierry.reding@gmail.com>, <shc_work@mail.ru>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>, <corbet@lwn.net>,
<nicolas.ferre@microchip.com>,
<alexandre.belloni@free-electrons.com>
Cc: <linux-pwm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH v5 2/9] pwm: clps711x: populate PWM mode in of_xlate function
Date: Tue, 22 May 2018 15:07:06 +0300 [thread overview]
Message-ID: <1526990833-30707-3-git-send-email-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <1526990833-30707-1-git-send-email-claudiu.beznea@microchip.com>
Populate PWM mode in of_xlate function to avoid pwm_apply_state() failure.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/pwm/pwm-clps711x.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-clps711x.c b/drivers/pwm/pwm-clps711x.c
index 26ec24e457b1..d742e8e375c7 100644
--- a/drivers/pwm/pwm-clps711x.c
+++ b/drivers/pwm/pwm-clps711x.c
@@ -109,10 +109,18 @@ static const struct pwm_ops clps711x_pwm_ops = {
static struct pwm_device *clps711x_pwm_xlate(struct pwm_chip *chip,
const struct of_phandle_args *args)
{
+ struct pwm_device *pwm;
+
if (args->args[0] >= chip->npwm)
return ERR_PTR(-EINVAL);
- return pwm_request_from_chip(chip, args->args[0], NULL);
+ pwm = pwm_request_from_chip(chip, args->args[0], NULL);
+ if (IS_ERR(pwm))
+ return pwm;
+
+ pwm->args.mode = pwm_mode_get_valid(chip, pwm);
+
+ return pwm;
}
static int clps711x_pwm_probe(struct platform_device *pdev)
--
2.7.4
next prev parent reply other threads:[~2018-05-22 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 12:07 [PATCH v5 0/9] extend PWM framework to support PWM modes Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 1/9] pwm: extend PWM framework with " Claudiu Beznea
2018-05-22 12:07 ` Claudiu Beznea [this message]
2018-05-22 12:07 ` [PATCH v5 3/9] pwm: cros-ec: populate PWM mode in of_xlate function Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 4/9] pwm: pxa: " Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 5/9] pwm: add PWM modes Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 6/9] pwm: atmel: add pwm capabilities Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 7/9] pwm: add push-pull mode support Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 8/9] pwm: add documentation for pwm push-pull mode Claudiu Beznea
2018-05-22 12:07 ` [PATCH v5 9/9] pwm: atmel: add push-pull mode support Claudiu Beznea
2018-07-18 7:07 ` [PATCH v5 0/9] extend PWM framework to support PWM modes Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526990833-30707-3-git-send-email-claudiu.beznea@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=corbet@lwn.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=shc_work@mail.ru \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).