From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A785BC6778C for ; Fri, 6 Jul 2018 08:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6107623F4C for ; Fri, 6 Jul 2018 08:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="USCnp/ui" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6107623F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbeGFIP4 (ORCPT ); Fri, 6 Jul 2018 04:15:56 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36887 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754158AbeGFIPw (ORCPT ); Fri, 6 Jul 2018 04:15:52 -0400 Received: by mail-pf0-f196.google.com with SMTP id h20-v6so7791503pfn.4 for ; Fri, 06 Jul 2018 01:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rtdc9EBZDt/OvCySy+SZxp4b3kXttIQe6tLhXTYwvQ4=; b=USCnp/uiMzpHz4l7FUGRPnJQ5OJWgyq5jcRAcHMwK4VWF+Oy7NYUrSFewXeCCPYfFW PvL25wDKKUGzA+8J35GblymiB98Gqiad4zJtIQNVfq2/oOqQ1uBWX14Gw6LlLkSOnXaH wCs1exMdtnsmmaDWdDdNt4l9y9vebHpJ6NuK+8USXtUFJsJN343AmRwgyoMrt50FD1nX o8cRgL90cJeT9kQ+A3OFdEtTVVCzOkVtfQJWt78/TdmRoQnd28AuiLUTGUeRjKb2lNf6 46qXBbk/BT7VjBvKVRmicsKYzvvIVS6luFB19UeOJIdkvMS3vXEhrzPM0u5b6Htv2+vG +Vxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rtdc9EBZDt/OvCySy+SZxp4b3kXttIQe6tLhXTYwvQ4=; b=slE8o5REYQH2wNI9dr/DIVgJlGfTpwkuQtVKi5/qcvNM367h+DyL+t8B0Md4gCsfsR gQPqaVrqltC59l529YRLds2wny/XbYcLvuWYQq1173CMDnlYXf/zNvYgUo1y62bNdQgQ Kzccur+7CTinb4vAo43TA4U6CqZIDyU/ou8dkpsUEZn1FeKyPJsEoeDtxzP1IDhChhqm 1Ck9UpoPIK4MEOYHZ39VlzmfXRUjgLc8bu2J6OqKkh4qGcw0DlaZ9YteVDlWHK0Y4US1 /CRwT0/YI9FEMdjtIOOfCF3ucN5gZAJ35pVdyiG56B/SK7oFELZcllqdC7ai4EqQUBTs izGA== X-Gm-Message-State: APt69E0SnfRy63bUvCdYbZkGHbTZq32JtftznyguugrsgeSkODupPAyn gySbFDkvvvl2DC8y24VM/BY= X-Google-Smtp-Source: AAOMgpetk0FDPvS72S6nqxbW6IfAlLwxw7wyhiDHKOk1N3Mvxo+w23y+iZbuIoWbiTvIZG/JjWTWXw== X-Received: by 2002:a65:6689:: with SMTP id b9-v6mr8487588pgw.326.1530864951959; Fri, 06 Jul 2018 01:15:51 -0700 (PDT) Received: from ct7host.localdomain ([38.106.11.25]) by smtp.gmail.com with ESMTPSA id c141-v6sm4673049pfc.25.2018.07.06.01.15.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 01:15:51 -0700 (PDT) From: Jia He To: Russell King , Andrew Morton , Michal Hocko , Catalin Marinas , Mel Gorman , Will Deacon , Mark Rutland , "H. Peter Anvin" Cc: Pavel Tatashin , Daniel Jordan , AKASHI Takahiro , Gioh Kim , Steven Sistare , Daniel Vacek , Eugeniu Rosca , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, James Morse , Ard Biesheuvel , Steve Capper , Thomas Gleixner , Ingo Molnar , Greg Kroah-Hartman , Kate Stewart , Philippe Ombredanne , Johannes Weiner , Kemi Wang , Petr Tesarik , YASUAKI ISHIMATSU , Andrey Ryabinin , Nikolay Borisov , richard.weiyang@gmail.com, Jia He Subject: [PATCH v10 5/6] mm/memblock: introduce pfn_valid_region() Date: Fri, 6 Jul 2018 16:14:19 +0800 Message-Id: <1530864860-7671-6-git-send-email-hejianet@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530864860-7671-1-git-send-email-hejianet@gmail.com> References: <1530864860-7671-1-git-send-email-hejianet@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia He Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns where possible") optimized the loop in memmap_init_zone(). But there is still some room for improvement. E.g. in early_pfn_valid(), we can record the last returned memblock region. If current pfn and last pfn are in the same memory region, we needn't do the unnecessary binary searches because memblock_is_nomap is the same result for whole memory region. Signed-off-by: Jia He --- mm/memblock.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/mm/memblock.c b/mm/memblock.c index c783b1a..274bd9f 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1188,6 +1188,30 @@ ulong __init_memblock memblock_next_valid_pfn(ulong pfn) return PHYS_PFN(regions[early_region_idx].base); } EXPORT_SYMBOL(memblock_next_valid_pfn); + +int pfn_valid_region(ulong pfn) +{ + ulong start_pfn, end_pfn; + struct memblock_type *type = &memblock.memory; + struct memblock_region *regions = type->regions; + + if (early_region_idx != -1) { + start_pfn = PFN_DOWN(regions[early_region_idx].base); + end_pfn = PFN_DOWN(regions[early_region_idx].base + + regions[early_region_idx].size); + + if (pfn >= start_pfn && pfn < end_pfn) + return !memblock_is_nomap( + ®ions[early_region_idx]); + } + + early_region_idx = memblock_search_pfn_regions(pfn); + if (early_region_idx == -1) + return false; + + return !memblock_is_nomap(®ions[early_region_idx]); +} +EXPORT_SYMBOL(pfn_valid_region); #endif /*CONFIG_HAVE_MEMBLOCK_PFN_VALID*/ static phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, -- 1.8.3.1