From: Stephen Boyd <sboyd@kernel.org>
To: Nicholas Mc Guire <hofrat@osadl.org>, Shawn Guo <shawnguo@kernel.org>
Cc: Frank Li <Frank.Li@freescale.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Nicholas Mc Guire <hofrat@osadl.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: imx6ul: fix missing of_node_put()
Date: Fri, 13 Jul 2018 09:27:30 -0700 [thread overview]
Message-ID: <153149925072.48062.9395649003513930129@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1531480400-7664-1-git-send-email-hofrat@osadl.org>
Quoting Nicholas Mc Guire (2018-07-13 04:13:20)
> of_find_compatible_node() is returning a device node with refcount
> incremented and must be explicitly decremented after the last use
> which is right after the us in of_iomap() here.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> Fixes: commit 787b4271a6a0 ("clk: imx: add imx6ul clk tree support")
This is not how a Fixes line works. It doesn't have 'commit'. I'll
remove it when applying so no need to resend.
next prev parent reply other threads:[~2018-07-13 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 11:13 [PATCH] clk: imx6ul: fix missing of_node_put() Nicholas Mc Guire
2018-07-13 16:27 ` Stephen Boyd [this message]
2018-07-13 16:41 ` Nicholas Mc Guire
2018-07-25 20:32 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153149925072.48062.9395649003513930129@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=Frank.Li@freescale.com \
--cc=fabio.estevam@nxp.com \
--cc=hofrat@osadl.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).