From: Andreas Ziegler <andreas.ziegler@fau.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Changbin Du <changbin.du@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Ziegler <andreas.ziegler@fau.de>
Subject: [PATCH 1/2] Documentation: {u,k}probes: fix filename for event enabling
Date: Mon, 16 Jul 2018 13:05:57 +0200 [thread overview]
Message-ID: <1531739158-31133-2-git-send-email-andreas.ziegler@fau.de> (raw)
In-Reply-To: <1531739158-31133-1-git-send-email-andreas.ziegler@fau.de>
The per-event files to enable or disable kprobes and uprobes
are named 'enable', not 'enabled'. Fix the corresponding
documentation.
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
Documentation/trace/kprobetrace.rst | 6 +++---
Documentation/trace/uprobetracer.rst | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst
index 3e0f971..c4aaef7d 100644
--- a/Documentation/trace/kprobetrace.rst
+++ b/Documentation/trace/kprobetrace.rst
@@ -18,7 +18,7 @@ To enable this feature, build your kernel with CONFIG_KPROBE_EVENTS=y.
Similar to the events tracer, this doesn't need to be activated via
current_tracer. Instead of that, add probe points via
/sys/kernel/debug/tracing/kprobe_events, and enable it via
-/sys/kernel/debug/tracing/events/kprobes/<EVENT>/enabled.
+/sys/kernel/debug/tracing/events/kprobes/<EVENT>/enable.
Synopsis of kprobe_events
@@ -81,9 +81,9 @@ Per-probe event filtering feature allows you to set different filter on each
probe and gives you what arguments will be shown in trace buffer. If an event
name is specified right after 'p:' or 'r:' in kprobe_events, it adds an event
under tracing/events/kprobes/<EVENT>, at the directory you can see 'id',
-'enabled', 'format' and 'filter'.
+'enable', 'format' and 'filter'.
-enabled:
+enable:
You can enable/disable the probe by writing 1 or 0 on it.
format:
diff --git a/Documentation/trace/uprobetracer.rst b/Documentation/trace/uprobetracer.rst
index 98d3f69..d082281 100644
--- a/Documentation/trace/uprobetracer.rst
+++ b/Documentation/trace/uprobetracer.rst
@@ -13,7 +13,7 @@ To enable this feature, build your kernel with CONFIG_UPROBE_EVENTS=y.
Similar to the kprobe-event tracer, this doesn't need to be activated via
current_tracer. Instead of that, add probe points via
/sys/kernel/debug/tracing/uprobe_events, and enable it via
-/sys/kernel/debug/tracing/events/uprobes/<EVENT>/enabled.
+/sys/kernel/debug/tracing/events/uprobes/<EVENT>/enable.
However unlike kprobe-event tracer, the uprobe event interface expects the
user to calculate the offset of the probepoint in the object.
--
2.7.4
next prev parent reply other threads:[~2018-07-16 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 11:05 [PATCH 0/2] Documentation: trace: improve probe documentation Andreas Ziegler
2018-07-16 11:05 ` Andreas Ziegler [this message]
2018-07-16 11:05 ` [PATCH 2/2] Documentation: kprobetrace: document 'trigger' file Andreas Ziegler
2018-07-23 15:26 ` [PATCH 0/2] Documentation: trace: improve probe documentation Jonathan Corbet
2018-07-23 15:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531739158-31133-2-git-send-email-andreas.ziegler@fau.de \
--to=andreas.ziegler@fau.de \
--cc=changbin.du@intel.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).