From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_MED, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE42CECDFBB for ; Wed, 18 Jul 2018 11:12:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85D0B206B7 for ; Wed, 18 Jul 2018 11:12:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="PW7MP8UE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85D0B206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729263AbeGRLuR (ORCPT ); Wed, 18 Jul 2018 07:50:17 -0400 Received: from mail-eopbgr730088.outbound.protection.outlook.com ([40.107.73.88]:21753 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727640AbeGRLuQ (ORCPT ); Wed, 18 Jul 2018 07:50:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k7A01kb+DQ6xtVT4DPamqUvV+NSg4CRbtsUCIUIWEJk=; b=PW7MP8UE59Y9Vxfm1bIR4d+D3vmAuCLEkNjzcbz4vmIAxqYl7EFnAJmgzOStYMRGhGwRAoa2N5nHCv4F0SZt/i0X9I1x+txE+fswCSWed7M6tuydnnz6wse4ai5oW38i2ugdcHT+Xg+u2oKE2PtxjBpwYt/cH3O052kSLQ2SAJE= Received: from BL0PR02CA0080.namprd02.prod.outlook.com (2603:10b6:208:51::21) by BLUPR0201MB1905.namprd02.prod.outlook.com (2a01:111:e400:58af::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Wed, 18 Jul 2018 11:12:48 +0000 Received: from CY1NAM02FT006.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::206) by BL0PR02CA0080.outlook.office365.com (2603:10b6:208:51::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.973.16 via Frontend Transport; Wed, 18 Jul 2018 11:12:48 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT006.mail.protection.outlook.com (10.152.74.104) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.952.17 via Frontend Transport; Wed, 18 Jul 2018 11:12:47 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:54305 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1ffkNy-0000un-U0; Wed, 18 Jul 2018 04:12:46 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1ffkNt-000325-BQ; Wed, 18 Jul 2018 04:12:41 -0700 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w6IBCWoU011684; Wed, 18 Jul 2018 04:12:32 -0700 Received: from [172.23.64.106] (helo=xhdvnc125.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1ffkNj-00031Q-RH; Wed, 18 Jul 2018 04:12:32 -0700 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id EC8B61213D6; Wed, 18 Jul 2018 16:42:30 +0530 (IST) From: Manish Narani To: , , , , , , , , CC: , Subject: [PATCH 2/4] iio: adc: xilinx: Remove dead code from xadc_zynq_setup Date: Wed, 18 Jul 2018 16:42:09 +0530 Message-ID: <1531912331-26431-3-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1531912331-26431-1-git-send-email-manish.narani@xilinx.com> References: <1531912331-26431-1-git-send-email-manish.narani@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(376002)(39860400002)(346002)(136003)(2980300002)(438002)(199004)(189003)(90966002)(72206003)(4326008)(103686004)(5660300001)(6266002)(47776003)(44832011)(486006)(50226002)(107886003)(446003)(478600001)(76176011)(316002)(11346002)(51416003)(2906002)(48376002)(50466002)(476003)(126002)(2616005)(106002)(42186006)(36386004)(26005)(186003)(54906003)(6666003)(16586007)(110136005)(426003)(336012)(8936002)(52956003)(8676002)(81166006)(106466001)(63266004)(2201001)(81156014)(356003)(36756003)(305945005)(107986001)(2101003)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0201MB1905;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;LANG:en;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT006;1:vW/PHEsqo/l+5aVA5lng79Qa1L+880QKs9yLoOl9YmZUqbD5mzuAHFlN3KJcIhCBlSCGllaWPl5GQtcg2Op9pokHRSEzhPr/HxWpiqWDMOB8tl9WJW8baIYXCOKFENVj MIME-Version: 1.0 Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15e82b70-ca42-4f38-78c1-08d5ec9f64cd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060);SRVR:BLUPR0201MB1905; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1905;3:uitTThR7P+lV1cp8jTicyER3zuTeslhB4QYRA9xDze/PJXe1xlghRpXgoe1O5URJ0IfMNnteA8v8KFYmo2msB9L76LDbEfOG1pRNpdFZrsulqr7xZkIldFSHSWU1O6ySwyFkTGcubb8joBLaE2/F/0qkgcEBDSc0XaqvrxOV1tbUtUVr2jM8WhwdJTNNt3+8LRb9r+wBhAfvHNJHEn81D3DvOauKtTRl7RxO+6Xigz6HTOqAbsmBj/wwvtuHZUakBI2IyXfptB/J0fdNIrUU2WZ0l4FKNmk3SMIyB9B/DzYya+zxy0vIxO0I8PkJzWAmaMNoPvjlhtNvPPbRLibFviBTzlZOrVzCoS+Qfg2bgSk=;25:Zrsa7fuTGO89meyxdS5Mt83L58FdVanxsSEgICs4rtNGfE5WscpYAP1eLF6GRphixZYb6tIgTMQswbhUwXNDgUV49S3dMCGFxlZSSq/517yxSA2R1Nsj54kY0OPjsfdlnJ1mHWBQorUmEDiwJ9Vc8ZcPfLMqBMi6+5WxyLII7PT55Y9y1pCJly1A7jpTZ1Z1pQmkIImkcPWa5VIO12NXyTJikb7tpzR6wzVrj8xclyIqjcRhIvWXtOioBAKz4P4bJXLulbICpBww1HL/HgVwVcqBbelghOLBmvQrNDVA55e2vfkSUEIH/B1EbzwaK4kz7Af9P7a+dTuks7q/Cbrm0AbAy+c2qORd1uLEwO70Gfg= X-MS-TrafficTypeDiagnostic: BLUPR0201MB1905: X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1905;31:CunrL8kYWBFZRmH080gL9QD+EhUMULccw9x+4cL1Ub0yUM6clas6V4cytbBYZSTh0L/XiUYRdc9h36vmQ5y26mrsBTA49WJTe/wKd5ivzkTe2ycCoFi87Ido/r+clAQQGKR72wEkYM3XIxrE5FE5es/s6Z/VgjmW8n9Fjs9+6t7cIuEZXeJCP2sjOuLA8V3RPWJgsprLNATxqQMcclOYUUsndUntXG1z20EUq/RUJEc=;20:LHSNohzP+lWd+oCWcFL0AB2LB0trKyOJ7BnH2O4QuupvOfJCGmBrJD7cEsLWbhlL9X5eJrYW5E3lS6G5YD0gsu1DyUgo/C5reOn0ZmEto0QeM9zI6Wq8qGr8nPro5npEoeFf8RqQ+N0D9FcQ6PYwtZiIJqKvvkkDDDuAdeoVGhvI6RbGhF+NO5Du/qw47J6KGGV5VUAoWxWW1WFiItQuO3tUXYxiGtUkM94TPS/wj6rDO46yWfVf2/RxJrlUkCxw7Ho9Kv01NBnP8/rY/jNH5vL8kchsrhSXNYaSGlJae+pH20LIJ4S2NVmz81lWMD04qzdA1W25tliH2zliX6ivUXuCsm01FBDYw0XnDJ15aEfx7dAG+aWsr4fTpX2hySVp/+ZihrH9fwhsuH3XSA9YUdR0SwZxcpcA7Kvf1TS68rNotpe9Cyb9187Ab8RhjI4WcEcEdUxbPcTmXwHl6Cf/RYthF650F2wCsJmzaOv44IBs4uLDufCsMfn+Dcgxzhed X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93004095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:BLUPR0201MB1905;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0201MB1905; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1905;4:oYtARYrZk/eQKWvdRu+0QCSM9aYstEh8uGuC9Vt/hSBR1Ujh91xwWeMHKE1BamroJyCQOuvaabLRUOItwbl2HEQ8TVGFQikDoul7iKRPJHvEygp3srZz1D/nD6jTZC4lAjKnBKq7goLgH+vDHICCB2ALFLuVEcHtj9Jnwi0l+ScaTu9j0IIW3KNMN8uR2tA8AEU+80NlrzEqGxqlC6/LdD+loYKSUz2qZG+k/grFbFgqkZJ4Smzbsg6PYLoBv8xQFwrH95W0jNYhn+sd5x9vkIw5sFZEgbFL8Jd8ZBOgvv/Dc5sZlt3IQrRB191JBUjY X-Forefront-PRVS: 0737B96801 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0201MB1905;23:NYDzSsB0D0Kxz2yoPgyV7DrJ6pcwrsBMBzpELHL?= =?us-ascii?Q?yrE+UZnlH2ONp+7cieCOLCB1Ph8+xagZkFWEhLK/eGL+tcYgwAL93PBOZVjU?= =?us-ascii?Q?2nIcu8a3y3jr6E+NK3jcxYx/ntxXIt5+rlM1AbJnIKP+9H/3UigFvJIjaBNU?= =?us-ascii?Q?kv0hl4qW6Oln239tvXHpiXHX83Js2En3R+fKV/TWip1GUgaH4qRCgRSIkdD+?= =?us-ascii?Q?Xv7C2OLcbqbNoyzxAhCH2lHxPOa9ypu84BVHuHDgxdM4zXdYzDxVwAg5AylV?= =?us-ascii?Q?e4UEjwlk5xfqlmtv+IQIMQeQ02T006sb386Dtz31YZhonrDtVUk33rRRC+j+?= =?us-ascii?Q?fdx6qVGlPuztAZ4IEcCT19bXGUEDj3t58uSBDSCRgJTp3MH3sy35ZawajRY2?= =?us-ascii?Q?pwtfBiACiBUZV7Y9rKgJEtYocn5uGJ1leYNz4abT6ASWGWPKROU2sCrl3OsT?= =?us-ascii?Q?83Dkuy32QZCnv7X1vOyQKPlI/hP6a2/jKEFUseTyhwtMaQQdWZOc/mm7me48?= =?us-ascii?Q?zx81jDzxcm7VNfxslYCenGzvNf7u/VZ2dKlH5nY7JgHr5vXPSXy5LNnI28Gp?= =?us-ascii?Q?XCul13kxu7oMyqL5oWcwbGAayRWSRyaMrJak6r5MzEKi4rVOe64vqtecYMA/?= =?us-ascii?Q?5ncyqAf1STzuPfPUBs5I1mvKXC/FT3lxdGmNCnF3u5324tC0BnkyEpvYarAZ?= =?us-ascii?Q?DnG3fBvElXMN47Oii1j9Hwd5ixNDf9qBXE/uPJWhrmeLaloCYbFV1z8Kw/dU?= =?us-ascii?Q?Ld9nZ3emvP3kZTCgVQIB2hTdQj4D8Lh5biUslU1ZEodtKjHShhfjI9BWUaI+?= =?us-ascii?Q?IhdfcdIP9bzL1yDpz2/U7Dt+VjKpSQNX5YMr2ojsYfju2gTXYAKK0CBnM9NS?= =?us-ascii?Q?Smcm7Ic6CjfhTWeZT/VyHm8FuTdrN3d1wzQqJpePlBvbeaCig7ec4/Gf+u3S?= =?us-ascii?Q?i0UoR0F814j1F0XeT6TmJDutmFhks7X7zSoE/sbkIaRl3OpQbn/FJpKKzZCh?= =?us-ascii?Q?d/xN5WHwclpO6WIcqw+UgRb8aBPmR/dCXMArgICSSsjO/S2eHIdwMDSbDQxM?= =?us-ascii?Q?iyObaGd5VrglmHlRh1p4l3qP2kSgd+kaMDRlM6QtQECq438ftmOI08TEmILA?= =?us-ascii?Q?o1jty2r5LpMX7KeDDUg9nOlCQFZfcevqIy1cqNyPpkatGWtSL5HwGy7Z58yA?= =?us-ascii?Q?KJUFGXFyIGDiNbisO/gnRBuSDSUfUA6coIftGThtZqyWsHikjgeKdYTv+zOm?= =?us-ascii?Q?6yQn24PMg/VW/vLcvOCURLRZSkLTRcflGfa5DDc41?= X-Microsoft-Antispam-Message-Info: Guf/yQlALXIX6dPO6V57UZ7Df4L+vplA6Y6g/7U4ZqzSCIouYtVl4tp4V2xbTReyidWPN/eNWhP7iUyfBtf1hnOs6iUWQVxJXSTcSicTWo0KWEJWvnZ9dnFWMlRezLysbTYyK46LTQS2dbpzAA9b8s9zpLCsATFt/wN0u+ttpJwOCj0l0mFjo8L9ae1POlm0h9odj6emyq8al9z3VoQxmhCR2FNgzinHEXfOT/4/1TU2AyfDMKSPG2yoxtGEvoNf8EXHraQR0vmdv0rBNrLv2hJmoqbQhPXCWQZTnYY1916+SjVDdnnfU8MSBS6jHIPDsaixc+CfrlIROJ8agl7AZxk5hYstp+sC4a8j0WXGEfg= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1905;6:AvvTnyayQSDcwKDG6NdizbLxWdWf4B7wBYkcy17hcixIgEXFBdZag/7RqsOiismfx/iy4/XorImzHyYofdKYWf7P0t0HClivLVeTB07p5q8ah6EVcPQT59Ns4l1zJVj3wwGen+HKTMLzH9TL/zqjYZyYq4DIr2Tj+m9uJS0Ps7uptbpRmtFgtM8iYwLbWvueTmTzcaL+d0uz20SdPQEWuqTLTMc1C1rOvsnoqzgxP52XHJfIoKu5iZZaFIiPEjHLujetp4r3IT3ndpuHoi77Aam1bfBZ2d7r9wIV9GuFZZueGN8flhGR1E8JCGbGxEhGuqqddz5lf7DqM0mp1gYh3Gs72AvStNDu+qKCEuw6XDB1Nplt27BygbOr0GYXeNNtY/n0xaZPTGR7lw4KpShC06fVotEJz0u6QShvm1cq8JcWvad0DqpSQY4Rhpofd3jf3Z5K9pkrcwwvA8MPOtCHcw==;5:cf5nJ0EAEg0lMJYMeIGAMAc/Y3OXv2UDUhBjKmXf1b4ElO/nQCp4zkTF4RWCqNLQ3xR/RY7QHVSfjLFXJBpSYOCgGvjWoD4r/MB0gluIDujyZxuKRCZdbatn1iR/RlO/2R5yeXk6z5okpq51DW/eKbsMLGtdmVoOXfmu6vARB9M=;7:74K5UZwL06gu39eabfACwemT2VunRkoUXDmxtgzE//x3lW9PUfS5tOSvu7yX7a4gwQt2wNWQsgWsZjx6OFY1yVKupjzv0+VHrVn8/glCcvGt8ipG4kbbGMi+qLBo6dJM+uDSksPsQGOYOvsg6+w8vp+wffok7sgtmXKyD8LFFKkK/9Y08DS9jHb5ugpoo7QhzcoiCrlTjB4KxqU5jv8lOkjIARU9ZVFs6k33nf82ePYYVCkYrpxMR5Cqf/FRggsN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2018 11:12:47.3716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15e82b70-ca42-4f38-78c1-08d5ec9f64cd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1905 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch removes dead code from xadc_zynq_setup. The condition "if (tck_rate > XADC_ZYNQ_TCK_RATE_MAX)" cannot be true at any point of time. There is also an incompatible parameter used in the code. This patch fixes the same reported by coverity. Signed-off-by: Manish Narani --- drivers/iio/adc/xilinx-xadc-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index 27b45df..248cffa 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -341,8 +341,6 @@ static int xadc_zynq_setup(struct platform_device *pdev, pcap_rate = clk_get_rate(xadc->clk); - if (tck_rate > XADC_ZYNQ_TCK_RATE_MAX) - tck_rate = XADC_ZYNQ_TCK_RATE_MAX; if (tck_rate > pcap_rate / 2) { div = 2; } else { @@ -1045,7 +1043,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np, unsigned int num_channels; const char *external_mux; u32 ext_mux_chan; - int reg; + u32 reg; int ret; *conf = 0; -- 2.1.1