linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arun Kumar Neelakantam <aneela@codeaurora.org>
To: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org,
	robh+dt@kernel.org, arnaud.pouliquen@st.com,
	andy.gross@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arun Kumar Neelakantam <aneela@codeaurora.org>
Subject: [PATCH V4 6/9] rpmsg: glink: Expose rpmsg name attr for glink
Date: Fri, 27 Jul 2018 17:47:26 +0530	[thread overview]
Message-ID: <1532693849-7037-7-git-send-email-aneela@codeaurora.org> (raw)
In-Reply-To: <1532693849-7037-1-git-send-email-aneela@codeaurora.org>

From: Chris Lew <clew@codeaurora.org>

Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.

Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
 drivers/rpmsg/qcom_glink_native.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 9f3d026..7b4ffa0 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1544,6 +1544,26 @@ static void qcom_glink_work(struct work_struct *work)
 	}
 }
 
+static ssize_t rpmsg_name_show(struct device *dev,
+			       struct device_attribute *attr, char *buf)
+{
+	int ret = 0;
+	const char *name;
+
+	ret = of_property_read_string(dev->of_node, "label", &name);
+	if (ret < 0)
+		name = dev->of_node->name;
+
+	return snprintf(buf, RPMSG_NAME_SIZE, "%s\n", name);
+}
+static DEVICE_ATTR_RO(rpmsg_name);
+
+static struct attribute *qcom_glink_attrs[] = {
+	&dev_attr_rpmsg_name.attr,
+	NULL
+};
+ATTRIBUTE_GROUPS(qcom_glink);
+
 static void qcom_glink_device_release(struct device *dev)
 {
 	struct rpmsg_device *rpdev = to_rpmsg_device(dev);
@@ -1593,6 +1613,12 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev,
 		return ERR_PTR(-ENOMEM);
 
 	glink->dev = dev;
+	glink->dev->groups = qcom_glink_groups;
+
+	ret = device_add_groups(dev, qcom_glink_groups);
+	if (ret)
+		dev_err(dev, "failed to add groups\n");
+
 	glink->tx_pipe = tx;
 	glink->rx_pipe = rx;
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  parent reply	other threads:[~2018-07-27 12:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 12:17 [PATCH V4 0/9] Add chrdev and name query support for GLINK Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 1/9] dt-bindings: soc: qcom: Add label for GLINK bindings Arun Kumar Neelakantam
2018-07-30 22:30   ` Rob Herring
2018-07-27 12:17 ` [PATCH V4 2/9] rpmsg: glink: Store edge name for glink device Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 3/9] rpmsg: glink: Use complete_all for open states Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 4/9] rpmsg: Guard against null endpoint ops in destroy Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 5/9] rpmsg: glink: Add support for rpmsg glink chrdev Arun Kumar Neelakantam
2018-07-27 12:17 ` Arun Kumar Neelakantam [this message]
2018-07-27 12:17 ` [PATCH V4 7/9] rpmsg: glink: Remove chunk size word align warning Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 8/9] rpmsg: glink: unregister rpmsg device during endpoint destroy Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 9/9] rpmsg: Add compat ioctl for rpmsg char driver Arun Kumar Neelakantam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532693849-7037-7-git-send-email-aneela@codeaurora.org \
    --to=aneela@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=clew@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).