From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Andreas Färber" <afaerber@suse.de>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
linux-clk@vger.kernel.org, liuwei@actions-semi.com,
mp-cs@actions-semi.com, 96boards@ucrobotics.com,
devicetree@vger.kernel.org, daniel.thompson@linaro.org,
amit.kucheria@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, hzhang@ucrobotics.com,
bdong@ucrobotics.com, manivannanece23@gmail.com,
thomas.liau@actions-semi.com, jeff.chen@actions-semi.com,
pn@denx.de, edgar.righi@lsitec.org.br, sravanhome@gmail.com
Subject: Re: [PATCH 0/9] Add Reset Controller support for Actions Semi Owl SoCs
Date: Mon, 30 Jul 2018 17:38:31 +0200 [thread overview]
Message-ID: <1532965111.3471.14.camel@pengutronix.de> (raw)
In-Reply-To: <20180730151131.GA28633@mani>
On Mon, 2018-07-30 at 20:41 +0530, Manivannan Sadhasivam wrote:
> Hi Andreas,
>
> On Mon, Jul 30, 2018 at 12:26:07PM +0200, Andreas Färber wrote:
> > Hi Mani,
> >
> > Am 27.07.2018 um 20:45 schrieb Manivannan Sadhasivam:
> > > This patchset adds Reset Controller (RMU) support for Actions Semi
> > > Owl SoCs, S900 and S700. For the Owl SoCs, RMU has been integrated into
> > > the clock subsystem in hardware. Hence, in software we integrate RMU
> > > support into common clock driver inorder to maintain compatibility.
> >
> > Can this not be placed into drivers/reset/ by using mfd-simple with a
> > sub-node in DT?
> >
>
> Actually I was not sure where to place this reset controller driver. When I
> looked into other similar ones such as sunxi, they just integrated into the
> clk subsystem. So I just chose that path. But yeah, this is hacky!
>
> But this RMU is not MFD by any means. Since the CMU (Clock) and RMU (Reset)
> are two separate IPs inside SoC, we shouldn't describe it as a MFD driver. Since
> RMU has only 2 registers, the HW designers decided to use up the CMU memory
> map. So, maybe syscon would be best option I think. What is your opinion?
Using syscon seems cleaner than stuffing the regmap into owl_clk_desc.
> Even if we go for syscon, we should place the reset driver within clk
> framework as I can see other SoCs like Mediatek are doing the same. But again
> I'm not sure!
Me neither. If the CMU and RMU are really separate and only share the
memory map, a syscon driver could live in drivers/reset without
problems.
It's only when there are interactions between clocks and resets that you
really want to have the reset driver integrated with clk.
regards
Philipp
next prev parent reply other threads:[~2018-07-30 15:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 18:45 [PATCH 0/9] Add Reset Controller support for Actions Semi Owl SoCs Manivannan Sadhasivam
2018-07-27 18:45 ` [PATCH 1/9] clk: actions: Cache regmap info in private clock descriptor Manivannan Sadhasivam
2018-07-27 18:45 ` [PATCH 2/9] dt-bindings: clock: Add reset controller bindings for Actions Semi Owl SoCs Manivannan Sadhasivam
2018-08-07 18:48 ` Rob Herring
2018-07-27 18:45 ` [PATCH 3/9] dt-bindings: reset: Add binding constants for Actions Semi S700 RMU Manivannan Sadhasivam
2018-08-07 18:49 ` Rob Herring
2018-07-27 18:45 ` [PATCH 4/9] dt-bindings: reset: Add binding constants for Actions Semi S900 RMU Manivannan Sadhasivam
2018-08-07 18:50 ` Rob Herring
2018-07-27 18:45 ` [PATCH 5/9] arm64: dts: actions: Add Reset Controller support for S700 SoC Manivannan Sadhasivam
2018-07-29 18:34 ` Parthiban Nallathambi
2018-07-27 18:45 ` [PATCH 6/9] arm64: dts: actions: Add Reset Controller support for S900 SoC Manivannan Sadhasivam
2018-07-27 18:45 ` [PATCH 7/9] clk: actions: Add Actions Semi Owl SoCs Reset Management Unit support Manivannan Sadhasivam
2018-07-30 10:21 ` Philipp Zabel
2018-08-01 3:34 ` Manivannan Sadhasivam
2018-07-27 18:45 ` [PATCH 8/9] clk: actions: Add Actions Semi S700 SoC " Manivannan Sadhasivam
2018-07-30 10:40 ` Philipp Zabel
2018-07-27 18:45 ` [PATCH 9/9] clk: actions: Add Actions Semi S900 " Manivannan Sadhasivam
2018-07-30 10:26 ` [PATCH 0/9] Add Reset Controller support for Actions Semi Owl SoCs Andreas Färber
2018-07-30 15:11 ` Manivannan Sadhasivam
2018-07-30 15:38 ` Philipp Zabel [this message]
2018-07-30 16:09 ` Manivannan Sadhasivam
2018-08-07 18:47 ` Rob Herring
2018-08-08 17:29 ` Manivannan Sadhasivam
2018-08-08 18:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532965111.3471.14.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=96boards@ucrobotics.com \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=bdong@ucrobotics.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edgar.righi@lsitec.org.br \
--cc=hzhang@ucrobotics.com \
--cc=jeff.chen@actions-semi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=manivannanece23@gmail.com \
--cc=mp-cs@actions-semi.com \
--cc=mturquette@baylibre.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sravanhome@gmail.com \
--cc=thomas.liau@actions-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).