From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A4CC43142 for ; Tue, 31 Jul 2018 08:57:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF8C220870 for ; Tue, 31 Jul 2018 08:57:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF8C220870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730017AbeGaKgY (ORCPT ); Tue, 31 Jul 2018 06:36:24 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:42091 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729766AbeGaKgY (ORCPT ); Tue, 31 Jul 2018 06:36:24 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1fkQSl-0006jr-Mk; Tue, 31 Jul 2018 10:57:03 +0200 Message-ID: <1533027423.3444.11.camel@pengutronix.de> Subject: Re: [PATCH 3/4] remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line From: Philipp Zabel To: Sibi Sankar , bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ohad@wizery.com, mark.rutland@arm.com, sricharan@codeaurora.org, akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org, tsoni@codeaurora.org Date: Tue, 31 Jul 2018 10:57:03 +0200 In-Reply-To: <20180727152811.15258-3-sibis@codeaurora.org> References: <20180727152811.15258-1-sibis@codeaurora.org> <20180727152811.15258-3-sibis@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote: > Explicitly get mss_restart to facilitate adding PDC > restart line for modem on SDM845 SoCs > > Signed-off-by: Sibi Sankar > --- > drivers/remoteproc/qcom_q6v5_pil.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c > index b1296d614b8b..d57fdb34e3dd 100644 > --- a/drivers/remoteproc/qcom_q6v5_pil.c > +++ b/drivers/remoteproc/qcom_q6v5_pil.c > @@ -1176,8 +1176,7 @@ static int q6v5_init_clocks(struct device *dev, struct clk **clks, > > static int q6v5_init_reset(struct q6v5 *qproc) > { > - qproc->mss_restart = devm_reset_control_get_exclusive(qproc->dev, > - NULL); > + qproc->mss_restart = devm_reset_control_get(qproc->dev, "mss_restart"); Please keep using devm_reset_control_get_exclusive. regards Philipp