* [PATCH] libnvdimm, bus: check id immediately following ida_simple_get
@ 2018-08-03 12:08 Ocean He
2018-08-03 17:13 ` Verma, Vishal L
2018-08-07 22:46 ` Dave Jiang
0 siblings, 2 replies; 3+ messages in thread
From: Ocean He @ 2018-08-03 12:08 UTC (permalink / raw)
To: dan.j.williams, ross.zwisler, vishal.l.verma, dave.jiang
Cc: linux-nvdimm, linux-kernel, Ocean He
From: Ocean He <hehy1@lenovo.com>
The id check was not executed immediately following ida_simple_get. Just
change the codes position, without function change.
Signed-off-by: Ocean He <hehy1@lenovo.com>
---
drivers/nvdimm/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
index 27902a8..ab28e7c 100644
--- a/drivers/nvdimm/bus.c
+++ b/drivers/nvdimm/bus.c
@@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent,
INIT_LIST_HEAD(&nvdimm_bus->mapping_list);
init_waitqueue_head(&nvdimm_bus->probe_wait);
nvdimm_bus->id = ida_simple_get(&nd_ida, 0, 0, GFP_KERNEL);
- mutex_init(&nvdimm_bus->reconfig_mutex);
- badrange_init(&nvdimm_bus->badrange);
if (nvdimm_bus->id < 0) {
kfree(nvdimm_bus);
return NULL;
}
+ mutex_init(&nvdimm_bus->reconfig_mutex);
+ badrange_init(&nvdimm_bus->badrange);
nvdimm_bus->nd_desc = nd_desc;
nvdimm_bus->dev.parent = parent;
nvdimm_bus->dev.release = nvdimm_bus_release;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libnvdimm, bus: check id immediately following ida_simple_get
2018-08-03 12:08 [PATCH] libnvdimm, bus: check id immediately following ida_simple_get Ocean He
@ 2018-08-03 17:13 ` Verma, Vishal L
2018-08-07 22:46 ` Dave Jiang
1 sibling, 0 replies; 3+ messages in thread
From: Verma, Vishal L @ 2018-08-03 17:13 UTC (permalink / raw)
To: Williams, Dan J, ross.zwisler, oceanhehy, Jiang, Dave
Cc: linux-kernel, linux-nvdimm, hehy1
On Fri, 2018-08-03 at 08:08 -0400, Ocean He wrote:
> From: Ocean He <hehy1@lenovo.com>
>
> The id check was not executed immediately following ida_simple_get.
> Just
> change the codes position, without function change.
>
> Signed-off-by: Ocean He <hehy1@lenovo.com>
> ---
> drivers/nvdimm/bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good, feel free to add
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> index 27902a8..ab28e7c 100644
> --- a/drivers/nvdimm/bus.c
> +++ b/drivers/nvdimm/bus.c
> @@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct
> device *parent,
> INIT_LIST_HEAD(&nvdimm_bus->mapping_list);
> init_waitqueue_head(&nvdimm_bus->probe_wait);
> nvdimm_bus->id = ida_simple_get(&nd_ida, 0, 0, GFP_KERNEL);
> - mutex_init(&nvdimm_bus->reconfig_mutex);
> - badrange_init(&nvdimm_bus->badrange);
> if (nvdimm_bus->id < 0) {
> kfree(nvdimm_bus);
> return NULL;
> }
> + mutex_init(&nvdimm_bus->reconfig_mutex);
> + badrange_init(&nvdimm_bus->badrange);
> nvdimm_bus->nd_desc = nd_desc;
> nvdimm_bus->dev.parent = parent;
> nvdimm_bus->dev.release = nvdimm_bus_release;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libnvdimm, bus: check id immediately following ida_simple_get
2018-08-03 12:08 [PATCH] libnvdimm, bus: check id immediately following ida_simple_get Ocean He
2018-08-03 17:13 ` Verma, Vishal L
@ 2018-08-07 22:46 ` Dave Jiang
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2018-08-07 22:46 UTC (permalink / raw)
To: Ocean He, dan.j.williams, ross.zwisler, vishal.l.verma
Cc: linux-nvdimm, linux-kernel, Ocean He
On 08/03/2018 05:08 AM, Ocean He wrote:
> From: Ocean He <hehy1@lenovo.com>
>
> The id check was not executed immediately following ida_simple_get. Just
> change the codes position, without function change.
>
> Signed-off-by: Ocean He <hehy1@lenovo.com>
Applied.
> ---
> drivers/nvdimm/bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> index 27902a8..ab28e7c 100644
> --- a/drivers/nvdimm/bus.c
> +++ b/drivers/nvdimm/bus.c
> @@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct device *parent,
> INIT_LIST_HEAD(&nvdimm_bus->mapping_list);
> init_waitqueue_head(&nvdimm_bus->probe_wait);
> nvdimm_bus->id = ida_simple_get(&nd_ida, 0, 0, GFP_KERNEL);
> - mutex_init(&nvdimm_bus->reconfig_mutex);
> - badrange_init(&nvdimm_bus->badrange);
> if (nvdimm_bus->id < 0) {
> kfree(nvdimm_bus);
> return NULL;
> }
> + mutex_init(&nvdimm_bus->reconfig_mutex);
> + badrange_init(&nvdimm_bus->badrange);
> nvdimm_bus->nd_desc = nd_desc;
> nvdimm_bus->dev.parent = parent;
> nvdimm_bus->dev.release = nvdimm_bus_release;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-07 22:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-03 12:08 [PATCH] libnvdimm, bus: check id immediately following ida_simple_get Ocean He
2018-08-03 17:13 ` Verma, Vishal L
2018-08-07 22:46 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).