From: Stu Hsieh <stu.hsieh@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
Matthias Brugger <matthias.bgg@gmail.com>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>
Subject: Re: [PATCH v2 11/15] drm/mediatek: add callback function to return OVL layer number
Date: Mon, 6 Aug 2018 19:54:32 +0800 [thread overview]
Message-ID: <1533556472.11190.71.camel@mtksdccf07> (raw)
In-Reply-To: <1533273092.31144.7.camel@mtksdaap41>
Hi, CK:
On Fri, 2018-08-03 at 13:11 +0800, CK Hu wrote:
> Hi, Stu:
>
> On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote:
> > This patch add callback function to return OVL layer number
> >
> > Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > index 978782a77629..a42cfa057f42 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > @@ -58,6 +58,7 @@
> > struct mtk_disp_ovl_data {
> > unsigned int addr;
> > bool fmt_rgb565_is_0;
> > + unsigned int layer_nr;
> > };
> >
> > /**
> > @@ -132,6 +133,13 @@ static void mtk_ovl_config(struct mtk_ddp_comp *comp, unsigned int w,
> > writel(0x0, comp->regs + DISP_REG_OVL_RST);
> > }
> >
> > +static unsigned int mtk_ovl_layer_nr(struct mtk_ddp_comp *comp)
> > +{
> > + struct mtk_disp_ovl *ovl = comp_to_ovl(comp);
> > +
> > + return ovl->data->layer_nr;
>
> For now, MT8173, MT2712, MT2701 OVL all has 4 layer, so you could return
> 4 here. Once a SoC OVL has another layer number, then modified the code
> to this statement.
>
> Regards,
> CK
>
OK
Regards,
Stu
> > +}
> > +
> > static void mtk_ovl_layer_on(struct mtk_ddp_comp *comp, unsigned int idx)
> > {
> > unsigned int reg;
> > @@ -221,6 +229,7 @@ static const struct mtk_ddp_comp_funcs mtk_disp_ovl_funcs = {
> > .stop = mtk_ovl_stop,
> > .enable_vblank = mtk_ovl_enable_vblank,
> > .disable_vblank = mtk_ovl_disable_vblank,
> > + .layer_nr = mtk_ovl_layer_nr,
> > .layer_on = mtk_ovl_layer_on,
> > .layer_off = mtk_ovl_layer_off,
> > .layer_config = mtk_ovl_layer_config,
> > @@ -319,6 +328,7 @@ static const struct mtk_disp_ovl_data mt2701_ovl_driver_data = {
> > static const struct mtk_disp_ovl_data mt8173_ovl_driver_data = {
> > .addr = DISP_REG_OVL_ADDR_MT8173,
> > .fmt_rgb565_is_0 = true,
> > + .layer_nr = 4,
> > };
> >
> > static const struct of_device_id mtk_disp_ovl_driver_dt_match[] = {
>
>
next prev parent reply other threads:[~2018-08-06 11:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 3:10 [PATCH v2 00/15] Add RDMA memory mode support for mediatek SOC MT2712 Stu Hsieh
2018-08-03 3:10 ` [PATCH v2 01/15] drm/mediatek: add connection from RDMA0 to DPI1 Stu Hsieh
2018-08-03 4:57 ` CK Hu
2018-08-03 3:10 ` [PATCH v2 02/15] drm/mediatek: add connection from RDMA0 to DSI1 Stu Hsieh
2018-08-03 4:58 ` CK Hu
2018-08-03 3:10 ` [PATCH v2 03/15] drm/mediatek: add connection from RDMA1 to DSI0 Stu Hsieh
2018-08-03 5:00 ` CK Hu
2018-08-03 3:10 ` [PATCH v2 04/15] drm/mediatek: add connection from RDMA2 " Stu Hsieh
2018-08-03 5:01 ` CK Hu
2018-08-03 3:10 ` [PATCH v2 05/15] drm/mediatek: add RDMA memory mode for crtc created Stu Hsieh
2018-08-03 3:10 ` [PATCH v2 06/15] drm/mediatek: add memory mode for RDMA Stu Hsieh
2018-08-03 3:11 ` [PATCH v2 07/15] drm/mediatek: add layer config to set RDMA for plane setting Stu Hsieh
2018-08-03 3:11 ` [PATCH v2 08/15] drm/mediatek: add RGB color format support for RDMA Stu Hsieh
2018-08-03 3:11 ` [PATCH v2 09/15] drm/mediatek: add YUYV/UYVY " Stu Hsieh
2018-08-03 3:11 ` [PATCH v2 10/15] drm/mediatek: add function to get layer number for component Stu Hsieh
2018-08-03 5:08 ` CK Hu
2018-08-03 3:11 ` [PATCH v2 11/15] drm/mediatek: add callback function to return OVL layer number Stu Hsieh
2018-08-03 5:11 ` CK Hu
2018-08-06 11:54 ` Stu Hsieh [this message]
2018-08-03 3:11 ` [PATCH v2 12/15] drm/mediatek: add callback function to return RDMA " Stu Hsieh
2018-08-03 5:13 ` CK Hu
2018-08-06 11:53 ` Stu Hsieh
2018-08-03 3:11 ` [PATCH v2 13/15] drm/mediatek: use layer_nr function to get layer number to init plane Stu Hsieh
2018-08-03 5:33 ` CK Hu
2018-08-06 11:55 ` Stu Hsieh
2018-08-03 3:11 ` [PATCH v2 14/15] drm/mediatek: update some variable name from ovl to comp Stu Hsieh
2018-08-03 5:34 ` CK Hu
2018-08-03 3:11 ` [PATCH v2 15/15] drm/mediatek: fix connection from RDMA2 to DSI1 Stu Hsieh
2018-08-03 5:36 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533556472.11190.71.camel@mtksdccf07 \
--to=stu.hsieh@mediatek.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).