* [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree
@ 2018-08-13 6:06 zhong jiang
2018-08-13 7:02 ` Nikolay Borisov
2018-08-15 11:51 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2018-08-13 6:06 UTC (permalink / raw)
To: clm, jbacik, dsterba; +Cc: linux-btrfs, linux-kernel
Kfree has taken the null pointer into account. So remove the check
before kfree.
The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/btrfs/free-space-cache.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index c3888c1..69d639f 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -2110,8 +2110,7 @@ static int insert_into_bitmap(struct btrfs_free_space_ctl *ctl,
out:
if (info) {
- if (info->bitmap)
- kfree(info->bitmap);
+ kfree(info->bitmap);
kmem_cache_free(btrfs_free_space_cachep, info);
}
@@ -3605,8 +3604,7 @@ int test_add_free_space_entry(struct btrfs_block_group_cache *cache,
if (info)
kmem_cache_free(btrfs_free_space_cachep, info);
- if (map)
- kfree(map);
+ kfree(map);
return 0;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree
2018-08-13 6:06 [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree zhong jiang
@ 2018-08-13 7:02 ` Nikolay Borisov
2018-08-15 11:51 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2018-08-13 7:02 UTC (permalink / raw)
To: zhong jiang, clm, jbacik, dsterba; +Cc: linux-btrfs, linux-kernel
On 13.08.2018 09:06, zhong jiang wrote:
> Kfree has taken the null pointer into account. So remove the check
> before kfree.
>
> The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/free-space-cache.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index c3888c1..69d639f 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -2110,8 +2110,7 @@ static int insert_into_bitmap(struct btrfs_free_space_ctl *ctl,
>
> out:
> if (info) {
> - if (info->bitmap)
> - kfree(info->bitmap);
> + kfree(info->bitmap);
> kmem_cache_free(btrfs_free_space_cachep, info);
> }
>
> @@ -3605,8 +3604,7 @@ int test_add_free_space_entry(struct btrfs_block_group_cache *cache,
>
> if (info)
> kmem_cache_free(btrfs_free_space_cachep, info);
> - if (map)
> - kfree(map);
> + kfree(map);
> return 0;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree
2018-08-13 6:06 [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree zhong jiang
2018-08-13 7:02 ` Nikolay Borisov
@ 2018-08-15 11:51 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2018-08-15 11:51 UTC (permalink / raw)
To: zhong jiang; +Cc: clm, jbacik, dsterba, linux-btrfs, linux-kernel
On Mon, Aug 13, 2018 at 02:06:08PM +0800, zhong jiang wrote:
> Kfree has taken the null pointer into account. So remove the check
> before kfree.
>
> The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-15 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-13 6:06 [PATCH] btrfs:free-space-cache: remove unneeded NULL check before kfree zhong jiang
2018-08-13 7:02 ` Nikolay Borisov
2018-08-15 11:51 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).