From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
To: <balbi@kernel.org>, <gregkh@linuxfoundation.org>
Cc: <v.anuragkumar@gmail.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Subject: [PATCH v2 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb()
Date: Fri, 17 Aug 2018 17:54:48 +0530 [thread overview]
Message-ID: <1534508695-12642-2-git-send-email-anurag.kumar.vulisha@xilinx.com> (raw)
In-Reply-To: <1534508695-12642-1-git-send-email-anurag.kumar.vulisha@xilinx.com>
Availability of TRB's are calculated using dwc3_calc_trbs_left(), which
determines available TRB's based on the HWO bit set in a TRB.
__dwc3_prepare_one_trb() is called with a TRB which needs to be prepared
for transfer. This __dwc3_prepare_one_trb() calls dwc3_calc_trbs_left()
to determine total available TRBs and set IOC bit if the total available
TRBs are zero. Since the present working TRB(which is passed as an
argument to __dwc3_prepare_one_trb() ) doesn't have HWO bit already set,
there are chances where dwc3_calc_trbs_left() wrongly calculates this
present working TRB as free(since the HWO bit is not yet set). This could
be a problem. This patch correct this issue by setting HWO bit before
calling dwc3_calc_trbs_left()
Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
---
Changes in v2:
1. Changed the commit message
---
drivers/usb/dwc3/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 69bf137..f73d219 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -990,6 +990,8 @@ static void __dwc3_prepare_one_trb(struct dwc3_ep *dep, struct dwc3_trb *trb,
trb->ctrl |= DWC3_TRB_CTRL_ISP_IMI;
}
+ trb->ctrl |= DWC3_TRB_CTRL_HWO;
+
if ((!no_interrupt && !chain) ||
(dwc3_calc_trbs_left(dep) == 0))
trb->ctrl |= DWC3_TRB_CTRL_IOC;
@@ -1000,8 +1002,6 @@ static void __dwc3_prepare_one_trb(struct dwc3_ep *dep, struct dwc3_trb *trb,
if (usb_endpoint_xfer_bulk(dep->endpoint.desc) && dep->stream_capable)
trb->ctrl |= DWC3_TRB_CTRL_SID_SOFN(stream_id);
- trb->ctrl |= DWC3_TRB_CTRL_HWO;
-
trace_dwc3_prepare_trb(dep, trb);
}
--
2.1.1
next prev parent reply other threads:[~2018-08-17 12:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 12:24 [PATCH v2 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Anurag Kumar Vulisha
2018-08-17 12:24 ` Anurag Kumar Vulisha [this message]
2018-09-05 5:33 ` [PATCH v2 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() Thinh Nguyen
2018-09-05 9:19 ` Anurag Kumar Vulisha
2018-09-06 1:58 ` Thinh Nguyen
2018-09-06 15:12 ` Anurag Kumar Vulisha
2018-09-07 2:00 ` Thinh Nguyen
2018-08-17 12:24 ` [PATCH v2 2/8] usb: dwc3: update stream id in depcmd Anurag Kumar Vulisha
2018-08-17 12:24 ` [PATCH v2 3/8] usb: dwc3: make controller clear transfer resources after complete Anurag Kumar Vulisha
2018-09-05 5:38 ` Thinh Nguyen
2018-09-05 9:21 ` Anurag Kumar Vulisha
2018-08-17 12:24 ` [PATCH v2 4/8] usb: dwc3: implement stream transfer timeout Anurag Kumar Vulisha
2018-09-05 6:01 ` Thinh Nguyen
2018-09-05 9:24 ` Anurag Kumar Vulisha
2018-08-17 12:24 ` [PATCH v2 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints Anurag Kumar Vulisha
2018-08-17 12:24 ` [PATCH v2 6/8] usb: dwc3: check for requests in started list " Anurag Kumar Vulisha
2018-08-17 12:24 ` [PATCH v2 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields Anurag Kumar Vulisha
2018-08-17 12:24 ` [PATCH v2 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints Anurag Kumar Vulisha
2018-09-04 9:44 ` [PATCH v2 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Anurag Kumar Vulisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534508695-12642-2-git-send-email-anurag.kumar.vulisha@xilinx.com \
--to=anurag.kumar.vulisha@xilinx.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=v.anuragkumar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).