* [PATCH] x86/build: remove jump label quirk for GCC older than 4.5.2
@ 2018-08-27 5:45 Masahiro Yamada
2018-08-30 9:40 ` [tip:x86/urgent] x86/build: Remove " tip-bot for Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2018-08-27 5:45 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, x86
Cc: Masahiro Yamada, linux-kbuild, H. Peter Anvin, linux-kernel,
Michal Marek
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.
Remove the workaround code.
It was the only user of cc-if-fullversion. Remove the macro as well.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/x86/Makefile | 12 ------------
scripts/Kbuild.include | 4 ----
2 files changed, 16 deletions(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index d6c10f3..a51d5dc 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -175,18 +175,6 @@ ifndef CC_HAVE_ASM_GOTO
$(error Compiler lacks asm-goto support.)
endif
-#
-# Jump labels need '-maccumulate-outgoing-args' for gcc < 4.5.2 to prevent a
-# GCC bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226). There's no way
-# to test for this bug at compile-time because the test case needs to execute,
-# which is a no-go for cross compilers. So check the GCC version instead.
-#
-ifdef CONFIG_JUMP_LABEL
- ifneq ($(ACCUMULATE_OUTGOING_ARGS), 1)
- ACCUMULATE_OUTGOING_ARGS = $(call cc-if-fullversion, -lt, 040502, 1)
- endif
-endif
-
ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1)
# This compiler flag is not supported by Clang:
KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args,)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index c75413d..ce53639 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -153,10 +153,6 @@ cc-fullversion = $(shell $(CONFIG_SHELL) \
# Usage: EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1)
cc-ifversion = $(shell [ $(cc-version) $(1) $(2) ] && echo $(3) || echo $(4))
-# cc-if-fullversion
-# Usage: EXTRA_CFLAGS += $(call cc-if-fullversion, -lt, 040502, -O1)
-cc-if-fullversion = $(shell [ $(cc-fullversion) $(1) $(2) ] && echo $(3) || echo $(4))
-
# cc-ldoption
# Usage: ldflags += $(call cc-ldoption, -Wl$(comma)--hash-style=both)
cc-ldoption = $(call try-run,\
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86/build: Remove jump label quirk for GCC older than 4.5.2
2018-08-27 5:45 [PATCH] x86/build: remove jump label quirk for GCC older than 4.5.2 Masahiro Yamada
@ 2018-08-30 9:40 ` tip-bot for Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Masahiro Yamada @ 2018-08-30 9:40 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, michal.lkml, yamada.masahiro, mingo, linux-kernel, hpa
Commit-ID: 36bf9da2913054c218337d8cd7cb11bddc1fafb0
Gitweb: https://git.kernel.org/tip/36bf9da2913054c218337d8cd7cb11bddc1fafb0
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
AuthorDate: Mon, 27 Aug 2018 14:45:14 +0900
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 30 Aug 2018 11:37:08 +0200
x86/build: Remove jump label quirk for GCC older than 4.5.2
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.
Remove the workaround code.
It was the only user of cc-if-fullversion. Remove the macro as well.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org
Link: https://lkml.kernel.org/r/1535348714-25457-1-git-send-email-yamada.masahiro@socionext.com
---
arch/x86/Makefile | 12 ------------
scripts/Kbuild.include | 4 ----
2 files changed, 16 deletions(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 94859241bc3e..8fc8f94ef5f5 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -179,18 +179,6 @@ ifndef CC_HAVE_ASM_GOTO
$(error Compiler lacks asm-goto support.)
endif
-#
-# Jump labels need '-maccumulate-outgoing-args' for gcc < 4.5.2 to prevent a
-# GCC bug (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226). There's no way
-# to test for this bug at compile-time because the test case needs to execute,
-# which is a no-go for cross compilers. So check the GCC version instead.
-#
-ifdef CONFIG_JUMP_LABEL
- ifneq ($(ACCUMULATE_OUTGOING_ARGS), 1)
- ACCUMULATE_OUTGOING_ARGS = $(call cc-if-fullversion, -lt, 040502, 1)
- endif
-endif
-
ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1)
# This compiler flag is not supported by Clang:
KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args,)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index c75413d05a63..ce53639a864a 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -153,10 +153,6 @@ cc-fullversion = $(shell $(CONFIG_SHELL) \
# Usage: EXTRA_CFLAGS += $(call cc-ifversion, -lt, 0402, -O1)
cc-ifversion = $(shell [ $(cc-version) $(1) $(2) ] && echo $(3) || echo $(4))
-# cc-if-fullversion
-# Usage: EXTRA_CFLAGS += $(call cc-if-fullversion, -lt, 040502, -O1)
-cc-if-fullversion = $(shell [ $(cc-fullversion) $(1) $(2) ] && echo $(3) || echo $(4))
-
# cc-ldoption
# Usage: ldflags += $(call cc-ldoption, -Wl$(comma)--hash-style=both)
cc-ldoption = $(call try-run,\
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-30 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 5:45 [PATCH] x86/build: remove jump label quirk for GCC older than 4.5.2 Masahiro Yamada
2018-08-30 9:40 ` [tip:x86/urgent] x86/build: Remove " tip-bot for Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).