From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98138C433F4 for ; Fri, 31 Aug 2018 17:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 374FA20839 for ; Fri, 31 Aug 2018 17:13:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZNdGpc0C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 374FA20839 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727881AbeHaVVd (ORCPT ); Fri, 31 Aug 2018 17:21:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:55106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727301AbeHaVVc (ORCPT ); Fri, 31 Aug 2018 17:21:32 -0400 Received: from localhost (unknown [104.132.0.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BEC42077C; Fri, 31 Aug 2018 17:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535735586; bh=uPJimPlF7yyKd+X1kPW5Svf3bKd3KY199sq6AbkdR/Q=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=ZNdGpc0ChTwoLOGayUjDCZKhqmf6qQhJoQj3lnr0glRwmHV4zCNIUmINbYCDfDZ+m 83y0klJYaHjzNak9VDg1cgfOXyuX/bAARUVgWbi2nk+9MdAQ/ndicAfd9YQ2oze3fx AJwmQWwV65x06PvCCHdGcaJMdS2fioaMpsHvhyew= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: "Zhu, Yi Xin" , Songjun Wu , chuanhua.lei@linux.intel.com, hua.ma@linux.intel.com, qi-ming.wu@intel.com From: Stephen Boyd In-Reply-To: <65a8518b-8fd8-847b-f952-0370be3d786a@linux.intel.com> Cc: linux-mips@linux-mips.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, Michael Turquette , linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland References: <20180803030237.3366-1-songjun.wu@linux.intel.com> <20180803030237.3366-3-songjun.wu@linux.intel.com> <153370742214.220756.2039365625963765922@swboyd.mtv.corp.google.com> <571d2d40-8728-fa7c-5d89-73d2a7b6293b@linux.intel.com> <153539697928.129321.2605078315090527674@swboyd.mtv.corp.google.com> <65a8518b-8fd8-847b-f952-0370be3d786a@linux.intel.com> Message-ID: <153573558557.93865.3835503209987304514@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs Date: Fri, 31 Aug 2018 10:13:05 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Zhu, Yi Xin (2018-08-29 03:34:26) > >>>> +} > >>>> + > >>>> +CLK_OF_DECLARE(intel_grx500_cgu, "intel,grx500-cgu", grx500_clk_ini= t); > >>> Any reason a platform driver can't be used instead of CLK_OF_DECLARE(= )? > >> It provides CPU clock which is used in early boot stage. > >> > > Ok. What is the CPU clock doing in early boot stage? Some sort of timer > > frequency? If the driver can be split into two pieces, one to handle the > > really early stuff that must be in place to get timers up and running > > and the other to register the rest of the clks that aren't critical from > > a regular platform driver it would be good. That's preferred model if > > something is super critical. > > > Just to make sure my approach is same as you think. > = > In the driver, there's two clock registrations. > = > - One through CLK_OF_DECLARE for early stage clocks. > = > - The other via platform driver for the non-critical clocks. You can use the same DT node for both parts, no need to split the node into two and use syscon here.