From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753072AbdLMBD6 (ORCPT ); Tue, 12 Dec 2017 20:03:58 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:63131 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbdLMBD4 (ORCPT ); Tue, 12 Dec 2017 20:03:56 -0500 From: "Rafael J. Wysocki" To: Arvind Yadav Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] powercap: Remove reassignment Date: Wed, 13 Dec 2017 02:03:14 +0100 Message-ID: <1535899.2uxoW1GXQ1@aspire.rjw.lan> In-Reply-To: <00329a239c8b1640a9e491b6a90a5b20fd45e42c.1510422357.git.arvind.yadav.cs@gmail.com> References: <00329a239c8b1640a9e491b6a90a5b20fd45e42c.1510422357.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, November 11, 2017 6:47:26 PM CET Arvind Yadav wrote: > It is not necessary to reassignment of 'result'. > Here, result is being initialized zero and then updated with > seed_constraint_attributes(). > class_register is enough to return successful and error value. > > Signed-off-by: Arvind Yadav > --- > drivers/powercap/powercap_sys.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c > index 5b10b50..64b2b25 100644 > --- a/drivers/powercap/powercap_sys.c > +++ b/drivers/powercap/powercap_sys.c > @@ -673,15 +673,13 @@ EXPORT_SYMBOL_GPL(powercap_unregister_control_type); > > static int __init powercap_init(void) > { > - int result = 0; > + int result; > > result = seed_constraint_attributes(); > if (result) > return result; > > - result = class_register(&powercap_class); > - > - return result; > + return class_register(&powercap_class); > } > > device_initcall(powercap_init); > Applied, thanks!