linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaejoong Kim <climbbb.kim@gmail.com>
To: linux-um@lists.infradead.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org,
	devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org,
	linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org,
	sparclinux@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>
Subject: [PATCH 08/25] tty: n_gsm: Change return type to void
Date: Tue,  4 Sep 2018 11:44:34 +0900	[thread overview]
Message-ID: <1536029091-4426-9-git-send-email-climbbb.kim@gmail.com> (raw)
In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com>

Since tty_port_install() always returns 0, the return type has changed
to void. Now apply this and remove the obsolete error check.

Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
 drivers/tty/n_gsm.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 86b7e20..c52fa2d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2917,7 +2917,6 @@ static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty)
 	unsigned int line = tty->index;
 	unsigned int mux = line >> 6;
 	bool alloc = false;
-	int ret;
 
 	line = line & 0x3F;
 
@@ -2949,14 +2948,8 @@ static int gsmtty_install(struct tty_driver *driver, struct tty_struct *tty)
 		mutex_unlock(&gsm->mutex);
 		return -ENOMEM;
 	}
-	ret = tty_port_install(&dlci->port, driver, tty);
-	if (ret) {
-		if (alloc)
-			dlci_put(dlci);
-		mutex_unlock(&gsm->mutex);
-		return ret;
-	}
 
+	tty_port_install(&dlci->port, driver, tty);
 	dlci_get(dlci);
 	dlci_get(gsm->dlci[0]);
 	mux_get(gsm);
-- 
2.7.4


  parent reply	other threads:[~2018-09-04  2:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  2:44 [PATCH 00/25] Change tty_port(standard)_install's return type Jaejoong Kim
2018-09-04  2:44 ` [PATCH 01/25] tty: Change return type to void Jaejoong Kim
2018-09-04 10:45   ` Sergei Shtylyov
     [not found]     ` <CAL6iAaKzDPe7CMGR8VOBZRsJqZuNB1=zek_YVvwcKnjimbox2g@mail.gmail.com>
2018-09-05  5:57       ` Jiri Slaby
2018-09-04  2:44 ` [PATCH 02/25] isdn: i4l: isdn_tty: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 03/25] s390: char: con3215: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 04/25] s390: char: tty3270: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 05/25] tty: hvc: hvc_console: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 06/25] tty: hvc: hvcs: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 07/25] tty: mips_ejtag_fdc: " Jaejoong Kim
2018-09-04  2:44 ` Jaejoong Kim [this message]
2018-09-04  2:44 ` [PATCH 09/25] tty: serial: kgdb_nmi: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 10/25] tty: synclink: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 11/25] tty: synclinkmp: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 12/25] tty: vt: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 13/25] usb: xhci: dbc: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 14/25] Bluetooth: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 15/25] um: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 16/25] isdn: capi: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 17/25] misc: pti: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 18/25] mmc: core: sdio_uart: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 19/25] staging: fwserial: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 20/25] staging: gdm724x: gdm_tty: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 21/25] staging: greybus: uart: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 22/25] tty: nozomi: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 23/25] tty: vcc: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 24/25] usb: cdc-acm: " Jaejoong Kim
2018-09-04  2:44 ` [PATCH 25/25] usb: usb-serial: " Jaejoong Kim
2018-09-04  4:42 ` [PATCH 00/25] Change tty_port(standard)_install's return type Sam Ravnborg
2018-09-12 14:41 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536029091-4426-9-git-send-email-climbbb.kim@gmail.com \
    --to=climbbb.kim@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=jslaby@suse.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).