From: David Howells <dhowells@redhat.com>
To: linux-api@vger.kernel.org, linux-kbuild@vger.kernel.org
Cc: Michal Marek <michal.lkml@markovi.net>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
keyrings@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-nilfs@vger.kernel.org, linux-nvdimm@lists.01.org,
"Michael S. Tsirkin" <mst@redhat.com>,
codalist@coda.cs.cmu.edu, coda@cs.cmu.edu,
coreteam@netfilter.org, Rob Clark <robdclark@gmail.com>,
linux-arm-msm@vger.kernel.org,
Kent Overstreet <kent.overstreet@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Takashi Iwai <tiwai@suse.com>,
linux-bcache@vger.kernel.org, Coly Li <colyli@suse.de>,
Jaroslav Kysela <perex@perex.cz>,
Jan Harkes <jaharkes@cs.cmu.edu>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
Jason Wang <jasowang@redhat.com>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
netfilter-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
moderated for non-subscribers <alsa-devel@alsa-project.org>,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dhowells@redhat.com
Subject: [RFC] UAPI: Check headers by compiling all together as C++
Date: Wed, 05 Sep 2018 16:54:27 +0100 [thread overview]
Message-ID: <153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk> (raw)
Here's a set of patches that inserts a step into the build process to make
sure that the UAPI headers can all be built together with C++ (if the
compiler being used supports C++). All but the final patch perform fixups,
including:
(1) Fix member names that conflict with C++ reserved words by providing
alternates that can be used anywhere. An anonymous union is used so
that that the conflicting name is still available outside of C++.
(2) Fix the use of flexible arrays in structs that get embedded (which is
illegal in C++).
(3) Remove the use of internal kernel structs in UAPI structures.
(4) Fix symbol collisions.
(5) Replace usage of u32 and co. with __u32 and co.
(6) Fix use of sparsely initialised arrays (which g++ doesn't implement).
(7) Remove some use of PAGE_SIZE since this isn't valid outside of the
kernel.
And lastly:
(8) Compile all of the UAPI headers (with a few exceptions) together as
C++ to catch new errors occurring as part of the regular build
process.
The patches can also be found here:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=uapi-check
Thanks,
David
---
David Howells (11):
UAPI: drm: Fix use of C++ keywords as structural members
UAPI: keys: Fix use of C++ keywords as structural members
UAPI: virtio_net: Fix use of C++ keywords as structural members
UAPI: bcache: Fix use of embedded flexible array
UAPI: coda: Don't use internal kernel structs in UAPI
UAPI: netfilter: Fix symbol collision issues
UAPI: nilfs2: Fix use of undefined byteswapping functions
UAPI: sound: Fix use of u32 and co. in UAPI headers
UAPI: ndctl: Fix g++-unsupported initialisation in headers
UAPI: ndctl: Remove use of PAGE_SIZE
UAPI: Check headers build for C++
Makefile | 1
include/linux/ndctl.h | 22 ++++
include/uapi/drm/i810_drm.h | 7 +
include/uapi/drm/msm_drm.h | 7 +
include/uapi/linux/bcache.h | 2
include/uapi/linux/coda_psdev.h | 4 +
include/uapi/linux/keyctl.h | 7 +
include/uapi/linux/ndctl.h | 20 ++-
include/uapi/linux/netfilter/nfnetlink_cthelper.h | 2
include/uapi/linux/netfilter_ipv4/ipt_ECN.h | 9 --
include/uapi/linux/nilfs2_ondisk.h | 21 ++--
include/uapi/linux/virtio_net.h | 7 +
include/uapi/sound/skl-tplg-interface.h | 106 +++++++++---------
scripts/headers-c++.sh | 124 +++++++++++++++++++++
14 files changed, 255 insertions(+), 84 deletions(-)
create mode 100644 include/linux/ndctl.h
create mode 100755 scripts/headers-c++.sh
next reply other threads:[~2018-09-05 15:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 15:54 David Howells [this message]
2018-09-05 15:54 ` [PATCH 01/11] UAPI: drm: Fix use of C++ keywords as structural members David Howells
2018-09-05 15:54 ` [PATCH 02/11] UAPI: keys: " David Howells
2018-09-05 15:54 ` [PATCH 03/11] UAPI: virtio_net: " David Howells
2018-09-05 16:54 ` Greg KH
2018-09-05 17:15 ` David Howells
2018-09-05 17:35 ` Michael S. Tsirkin
2018-09-06 7:09 ` David Howells
2018-09-06 14:36 ` Michael S. Tsirkin
2018-09-05 15:55 ` [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array David Howells
2018-10-02 14:52 ` Jan Engelhardt
2018-10-09 15:41 ` David Howells
2018-10-09 16:54 ` Jan Engelhardt
2018-09-05 15:55 ` [PATCH 05/11] UAPI: coda: Don't use internal kernel structs in UAPI David Howells
2018-09-05 16:54 ` Jan Harkes
2018-09-05 17:12 ` Yann Droneaud
2018-09-05 17:28 ` Jan Harkes
2018-09-05 17:24 ` David Howells
2018-09-06 7:13 ` David Howells
2018-09-06 11:52 ` Yann Droneaud
2018-09-06 12:16 ` Jan Harkes
2018-09-06 14:53 ` David Howells
2018-09-05 15:55 ` [PATCH 06/11] UAPI: netfilter: Fix symbol collision issues David Howells
2018-09-05 15:55 ` [PATCH 07/11] UAPI: nilfs2: Fix use of undefined byteswapping functions David Howells
2018-09-05 22:20 ` Al Viro
2018-09-05 15:55 ` [PATCH 08/11] UAPI: sound: Fix use of u32 and co. in UAPI headers David Howells
2018-09-06 5:59 ` Takashi Sakamoto
2018-09-06 8:17 ` David Howells
2018-09-05 15:55 ` [PATCH 09/11] UAPI: ndctl: Fix g++-unsupported initialisation in headers David Howells
2018-09-05 15:55 ` [PATCH 10/11] UAPI: ndctl: Remove use of PAGE_SIZE David Howells
2018-09-05 15:55 ` [PATCH 11/11] UAPI: Check headers build for C++ David Howells
2018-09-05 16:55 ` [RFC] UAPI: Check headers by compiling all together as C++ Greg KH
2018-09-05 17:33 ` Yann Droneaud
2018-09-05 17:42 ` Michael S. Tsirkin
2018-09-06 7:12 ` Yann Droneaud
2018-09-05 19:22 ` Jan Engelhardt
2018-09-05 17:50 ` David Howells
2018-09-05 18:59 Alexey Dobriyan
2018-09-05 19:26 ` Greg KH
2018-09-05 19:31 ` Alexey Dobriyan
2018-09-05 22:22 ` Al Viro
2018-09-13 22:01 ` Alexey Dobriyan
2018-09-13 22:15 ` Al Viro
2018-09-13 23:27 ` David Howells
2018-09-13 23:42 ` Al Viro
2018-09-05 19:53 ` David Howells
2018-09-06 9:18 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153616286704.23468.584491117180383924.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=colyli@suse.de \
--cc=coreteam@netfilter.org \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jaharkes@cs.cmu.edu \
--cc=jasowang@redhat.com \
--cc=kent.overstreet@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=michal.lkml@markovi.net \
--cc=mst@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robdclark@gmail.com \
--cc=tiwai@suse.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).