From: Atish Patra <atish.patra@wdc.com>
To: palmer@sifive.com, linux-riscv@lists.infradead.org,
hch@infradead.org, anup@brainfault.org
Cc: mark.rutland@arm.com, atish.patra@wdc.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, Damien.LeMoal@wdc.com,
marc.zyngier@arm.com, jeremy.linton@arm.com,
gregkh@linuxfoundation.org, jason@lakedaemon.net,
catalin.marinas@arm.com, dmitriy@oss-tech.org,
ard.biesheuvel@linaro.org
Subject: [PATCH v3 07/12] RISC-V: Rename im_okay_therefore_i_am to found_boot_cpu
Date: Thu, 6 Sep 2018 01:05:30 -0700 [thread overview]
Message-ID: <1536221135-182613-8-git-send-email-atish.patra@wdc.com> (raw)
In-Reply-To: <1536221135-182613-1-git-send-email-atish.patra@wdc.com>
From: Palmer Dabbelt <palmer@sifive.com>
The old name was a bit odd.
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
Signed-off-by: Atish Patra <atish.patra@wdc.com>
---
arch/riscv/kernel/smpboot.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
index cfb0b02d..4a232600 100644
--- a/arch/riscv/kernel/smpboot.c
+++ b/arch/riscv/kernel/smpboot.c
@@ -50,7 +50,8 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
void __init setup_smp(void)
{
struct device_node *dn = NULL;
- int hart, im_okay_therefore_i_am = 0;
+ int hart;
+ bool found_boot_cpu = false;
while ((dn = of_find_node_by_type(dn, "cpu"))) {
hart = riscv_of_processor_hartid(dn);
@@ -58,13 +59,13 @@ void __init setup_smp(void)
set_cpu_possible(hart, true);
set_cpu_present(hart, true);
if (hart == smp_processor_id()) {
- BUG_ON(im_okay_therefore_i_am);
- im_okay_therefore_i_am = 1;
+ BUG_ON(found_boot_cpu);
+ found_boot_cpu = true;
}
}
}
- BUG_ON(!im_okay_therefore_i_am);
+ BUG_ON(!found_boot_cpu);
}
int __cpu_up(unsigned int cpu, struct task_struct *tidle)
--
2.7.4
next prev parent reply other threads:[~2018-09-06 8:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 8:05 [PATCH v3 00/12] SMP cleanup and new features Atish Patra
2018-09-06 8:05 ` [PATCH v3 01/12] RISC-V: Don't set cacheinfo.{physical_line_partition,attributes} Atish Patra
2018-09-06 8:05 ` [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo Atish Patra
2018-09-10 11:24 ` Christoph Hellwig
2018-09-11 1:35 ` Atish Patra
2018-09-06 8:05 ` [PATCH v3 03/12] RISC-V: Comment on the TLB flush in smp_callin() Atish Patra
2018-09-10 11:24 ` Christoph Hellwig
2018-09-06 8:05 ` [PATCH v3 04/12] RISC-V: Disable preemption before enabling interrupts Atish Patra
2018-09-10 11:24 ` Christoph Hellwig
2018-09-06 8:05 ` [PATCH v3 05/12] RISC-V: Provide a cleaner raw_smp_processor_id() Atish Patra
2018-09-10 11:25 ` Christoph Hellwig
2018-09-06 8:05 ` [PATCH v3 06/12] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid Atish Patra
2018-09-10 11:25 ` Christoph Hellwig
2018-09-11 1:36 ` Atish Patra
2018-09-11 6:17 ` Christoph Hellwig
2018-09-06 8:05 ` Atish Patra [this message]
2018-09-10 11:26 ` [PATCH v3 07/12] RISC-V: Rename im_okay_therefore_i_am to found_boot_cpu Christoph Hellwig
2018-09-06 8:05 ` [PATCH v3 08/12] RISC-V: Use mmgrab() Atish Patra
2018-09-06 8:05 ` [PATCH v3 09/12] RISC-V: User WRITE_ONCE instead of direct access Atish Patra
2018-09-10 11:27 ` Christoph Hellwig
2018-09-06 8:05 ` [PATCH v3 10/12] RISC-V: Add logical CPU indexing for RISC-V Atish Patra
2018-09-10 11:27 ` Christoph Hellwig
2018-09-06 8:05 ` [PATCH v3 11/12] RISC-V: Use Linux logical cpu number instead of hartid Atish Patra
2018-09-10 11:29 ` Christoph Hellwig
2018-09-11 1:35 ` Atish Patra
2018-09-06 8:05 ` [PATCH v3 12/12] RISC-V: Support cpu hotplug Atish Patra
2018-09-06 10:20 ` Mark Rutland
2018-09-06 18:25 ` Atish Patra
2018-09-11 18:36 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536221135-182613-8-git-send-email-atish.patra@wdc.com \
--to=atish.patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=anup@brainfault.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=dmitriy@oss-tech.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jason@lakedaemon.net \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).