* [PATCH] net: ibm: remove a redundant local variable 'k'
@ 2018-09-19 14:23 zhong jiang
2018-09-20 4:26 ` David Miller
2018-09-20 9:49 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2018-09-19 14:23 UTC (permalink / raw)
To: davem; +Cc: dougmill, netdev, linux-kernel
The local variable 'k' is never used after being assigned.
hence it should be redundant adn can be removed.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/ethernet/ibm/ehea/ehea_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index ba580bf..7f6a401 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -778,12 +778,11 @@ static void check_sqs(struct ehea_port *port)
{
struct ehea_swqe *swqe;
int swqe_index;
- int i, k;
+ int i;
for (i = 0; i < port->num_def_qps; i++) {
struct ehea_port_res *pr = &port->port_res[i];
int ret;
- k = 0;
swqe = ehea_get_swqe(pr->qp, &swqe_index);
memset(swqe, 0, SWQE_HEADER_SIZE);
atomic_dec(&pr->swqe_avail);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ibm: remove a redundant local variable 'k'
2018-09-19 14:23 [PATCH] net: ibm: remove a redundant local variable 'k' zhong jiang
@ 2018-09-20 4:26 ` David Miller
2018-09-20 9:49 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-09-20 4:26 UTC (permalink / raw)
To: zhongjiang; +Cc: dougmill, netdev, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
Date: Wed, 19 Sep 2018 22:23:15 +0800
> The local variable 'k' is never used after being assigned.
> hence it should be redundant adn can be removed.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ibm: remove a redundant local variable 'k'
2018-09-19 14:23 [PATCH] net: ibm: remove a redundant local variable 'k' zhong jiang
2018-09-20 4:26 ` David Miller
@ 2018-09-20 9:49 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2018-09-20 9:49 UTC (permalink / raw)
To: zhong jiang, davem; +Cc: dougmill, netdev, linux-kernel
Hello!
On 9/19/2018 5:23 PM, zhong jiang wrote:
> The local variable 'k' is never used after being assigned.
> hence it should be redundant adn can be removed.
Can.
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-20 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 14:23 [PATCH] net: ibm: remove a redundant local variable 'k' zhong jiang
2018-09-20 4:26 ` David Miller
2018-09-20 9:49 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).