From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, Dietmar.Eggemann@arm.com,
patrick.bellasi@arm.com
Subject: [PATCH v2 1/2] sched/fair: Cleanup load_balance() condition
Date: Wed, 26 Sep 2018 16:12:06 +0100 [thread overview]
Message-ID: <1537974727-30788-1-git-send-email-valentin.schneider@arm.com> (raw)
The alignment of the condition is off, clean that up.
Also, logical operators have lower precedence than bitwise/relational
operators, so remove one layer of parentheses to make the condition a
bit simpler to follow.
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
kernel/sched/fair.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 6bd142d..9cf93ba 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8783,9 +8783,9 @@ static int load_balance(int this_cpu, struct rq *this_rq,
out_one_pinned:
/* tune up the balancing interval */
- if (((env.flags & LBF_ALL_PINNED) &&
- sd->balance_interval < MAX_PINNED_INTERVAL) ||
- (sd->balance_interval < sd->max_interval))
+ if ((env.flags & LBF_ALL_PINNED &&
+ sd->balance_interval < MAX_PINNED_INTERVAL) ||
+ sd->balance_interval < sd->max_interval)
sd->balance_interval *= 2;
ld_moved = 0;
--
2.7.4
next reply other threads:[~2018-09-26 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 15:12 Valentin Schneider [this message]
2018-09-26 15:12 ` [PATCH v2 2/2] sched/fair: Don't increase sd->balance_interval on newidle balance Valentin Schneider
2018-11-04 0:13 ` [tip:sched/core] " tip-bot for Valentin Schneider
2018-10-30 10:27 ` [PATCH v2 1/2] sched/fair: Cleanup load_balance() condition Valentin Schneider
2018-10-30 12:41 ` Peter Zijlstra
2018-11-04 0:13 ` [tip:sched/core] sched/fair: Clean up " tip-bot for Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537974727-30788-1-git-send-email-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).