linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zeng Tao <prime.zeng@hisilicon.com>
To: <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>,
	<mathias.nyman@linux.intel.com>, <drinkcat@chromium.org>,
	<felipe.balbi@linux.intel.com>, <drake@endlessm.com>,
	<ravisadineni@chromium.org>, <joe@perches.com>
Cc: <prime.zeng@hisilicon.com>, Jonathan Corbet <corbet@lwn.net>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	"Thymo van Beers" <thymovanbeers@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	David Rientjes <rientjes@google.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: [PATCH] usb: hub: try old enumeration scheme first for high speed devices
Date: Fri, 28 Sep 2018 19:27:52 +0800	[thread overview]
Message-ID: <1538134077-14542-1-git-send-email-prime.zeng@hisilicon.com> (raw)

The new scheme is required just to support legacy low and full-speed
devices. For high speed devices, it will slower the enumeration speed.
So in this patch we try the "old" enumeration scheme first for high speed
devices, and this is what Windows does since Windows 8.

Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Reviewed-by: Roger Quadros <rogerq@ti.com>
---
 Documentation/admin-guide/kernel-parameters.txt | 3 ++-
 drivers/usb/core/hub.c                          | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 92eb1f4..151c527 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -4610,7 +4610,8 @@
 
 	usbcore.old_scheme_first=
 			[USB] Start with the old device initialization
-			scheme (default 0 = off).
+			scheme,  applies only to low and full-speed devices
+			 (default 0 = off).
 
 	usbcore.usbfs_memory_mb=
 			[USB] Memory limit (in MB) for buffers allocated by
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 462ce49..fb4e6bb 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2660,11 +2660,13 @@ static bool use_new_scheme(struct usb_device *udev, int retry,
 {
 	int old_scheme_first_port =
 		port_dev->quirks & USB_PORT_QUIRK_OLD_SCHEME;
+	int quick_enumeration = (udev->speed == USB_SPEED_HIGH);
 
 	if (udev->speed >= USB_SPEED_SUPER)
 		return false;
 
-	return USE_NEW_SCHEME(retry, old_scheme_first_port || old_scheme_first);
+	return USE_NEW_SCHEME(retry, old_scheme_first_port || old_scheme_first
+			      || quick_enumeration);
 }
 
 /* Is a USB 3.0 port in the Inactive or Compliance Mode state?
-- 
2.7.4


             reply	other threads:[~2018-09-28  3:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 11:27 Zeng Tao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-08-10 15:01 [PATCH] usb: hub: try old enumeration scheme first for high speed devices Zeng Tao
2018-08-10 10:50 ` Roger Quadros
2018-08-10 14:19   ` Alan Stern
2018-08-14  7:35     ` Zengtao (B)
2018-08-14 14:39       ` Alan Stern
2018-08-16  6:21         ` Zengtao (B)
2018-08-16  7:16           ` Roger Quadros
2018-08-16 10:59             ` Zengtao (B)
2018-08-16 11:13               ` Roger Quadros
2018-08-17  2:15                 ` Zengtao (B)
2018-08-14  7:33   ` Zengtao (B)
2018-08-16  7:31     ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538134077-14542-1-git-send-email-prime.zeng@hisilicon.com \
    --to=prime.zeng@hisilicon.com \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=drake@endlessm.com \
    --cc=drinkcat@chromium.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.cz \
    --cc=joe@perches.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mingo@kernel.org \
    --cc=ravisadineni@chromium.org \
    --cc=rientjes@google.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=thymovanbeers@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).