From: Vincent Guittot <vincent.guittot@linaro.org>
To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org
Cc: valentin.schneider@arm.com, Morten.Rasmussen@arm.com,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: [RESEND PATCH 2/3] sched/fair: trigger asym_packing during idle load balance
Date: Tue, 2 Oct 2018 09:26:38 +0200 [thread overview]
Message-ID: <1538465199-20176-3-git-send-email-vincent.guittot@linaro.org> (raw)
In-Reply-To: <1538465199-20176-1-git-send-email-vincent.guittot@linaro.org>
newly idle load balance is not always triggered when a cpu becomes idle.
This prevent the scheduler to get a chance to migrate task for asym packing.
Enable active migration because of asym packing during idle load balance too.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0ed99ad2..00f2171 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8460,7 +8460,7 @@ static int need_active_balance(struct lb_env *env)
{
struct sched_domain *sd = env->sd;
- if (env->idle == CPU_NEWLY_IDLE) {
+ if (env->idle != CPU_NOT_IDLE) {
/*
* ASYM_PACKING needs to force migrate tasks from busy but
--
2.7.4
next prev parent reply other threads:[~2018-10-02 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 7:26 [RESEND PATCH 0/3] sched/fair: some fixes for asym_packing Vincent Guittot
2018-10-02 7:26 ` [RESEND PATCH 1/3] sched/fair: fix rounding issue for asym packing Vincent Guittot
2018-10-02 7:26 ` Vincent Guittot [this message]
2018-10-02 7:26 ` [RESEND PATCH 3/3] sched/fair: fix unnecessary increase of balance interval Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538465199-20176-3-git-send-email-vincent.guittot@linaro.org \
--to=vincent.guittot@linaro.org \
--cc=Morten.Rasmussen@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).