From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: marex@denx.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA
Date: Fri, 05 Oct 2018 17:30:20 +0200 [thread overview]
Message-ID: <1538753420.3545.39.camel@pengutronix.de> (raw)
In-Reply-To: <04f701c1-8f1c-ee99-6797-cfbe769ebbc7@kernel.org>
Hi Dinh,
On Fri, 2018-10-05 at 10:17 -0500, Dinh Nguyen wrote:
[...]
> > > +static int a10_reset_init(struct device_node *np)
> > > +{
> > > + struct reset_simple_data *data;
> > > + struct resource res;
> > > + resource_size_t size;
> > > + int ret;
> > > + u32 reg_offset = 0;
> >
> > ... now it is 0x0.
> > I think this should be
> >
> > u32 reg_offset = 0x10;
> >
> > to avoid breaking SocFPGA with ancient device trees.
[...]
> > Could we keep the SOCFPGA_NR_BANKS #define to reduce the amount of magic
> > numbers?
> >
> > I can make both changes when applying if you want.
> >
>
> If you don't mind, that would be great!
Done, applied to reset/next with the above changes.
I get the following build warning:
drivers/reset/reset-socfpga.c:81:13: warning: symbol 'socfpga_reset_init' was not declared. Should it be static?
It would be nice to put the declaration into a header in
include/soc/socfpga (or wherever is more appropriate) at some point.
regards
Philipp
next prev parent reply other threads:[~2018-10-05 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 14:50 [PATCH] reset: socfpga: add an early reset driver for SoCFPGA Dinh Nguyen
2018-09-26 13:41 ` Dinh Nguyen
2018-10-04 9:53 ` Philipp Zabel
2018-10-05 15:17 ` Dinh Nguyen
2018-10-05 15:30 ` Philipp Zabel [this message]
2018-10-05 20:23 ` Dinh Nguyen
2018-10-08 7:42 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538753420.3545.39.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).