linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Taniya Das <tdas@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v5 2/2] clk: qcom: Add lpass clock controller driver for SDM845
Date: Sun, 07 Oct 2018 19:45:51 -0700	[thread overview]
Message-ID: <153896675144.119890.3991549600874849177@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <66fc65d8-92ec-f32c-6edb-ad4952695395@codeaurora.org>

Quoting Taniya Das (2018-10-04 05:01:27)
> 
> On 9/29/2018 12:21 AM, Stephen Boyd wrote:
> > Quoting Taniya Das (2018-09-18 03:25:38)
> >> @@ -3469,6 +3495,8 @@ enum {
> >>          [GCC_QSPI_CORE_CLK_SRC] = &gcc_qspi_core_clk_src.clkr,
> >>          [GCC_QSPI_CORE_CLK] = &gcc_qspi_core_clk.clkr,
> >>          [GCC_QSPI_CNOC_PERIPH_AHB_CLK] = &gcc_qspi_cnoc_periph_ahb_clk.clkr,
> >> +       [GCC_LPASS_Q6_AXI_CLK] = NULL,
> >> +       [GCC_LPASS_SWAY_CLK] = NULL,
> >>   };
> >>   
> >>   static const struct qcom_reset_map gcc_sdm845_resets[] = {
> >> @@ -3583,6 +3611,13 @@ static int gcc_sdm845_probe(struct platform_device *pdev)
> >>          if (ret)
> >>                  return ret;
> >>   
> >> +       if (of_property_read_bool(pdev->dev.of_node, "qcom,lpass-protected")) {
> > 
> > Shouldn't this be negated? So that we only add the clks when lpass isn't
> > protected?
> >
> 
> I was of the opinion to add the flag only when LPASS clocks are 
> required. But I am fine negating it too.

It's stating that lpass clks are protected, so presumably we wouldn't
add the property on devices without the XPU configured. This means that
most configurations would have it protected and then this flag is needed
almost all the time. O well!


      reply	other threads:[~2018-10-08  2:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 10:25 [PATCH v5 0/2] Add support for LPASS clock controller for SDM845 Taniya Das
2018-09-18 10:25 ` [PATCH v5 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings Taniya Das
2018-09-26 22:47   ` Rob Herring
2018-09-28 18:52   ` Stephen Boyd
2018-09-18 10:25 ` [PATCH v5 2/2] clk: qcom: Add lpass clock controller driver for SDM845 Taniya Das
2018-09-28 18:51   ` Stephen Boyd
2018-10-04 12:01     ` Taniya Das
2018-10-08  2:45       ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153896675144.119890.3991549600874849177@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).