* [PATCH] clk: keystone: add missing MODULE_LICENSE
@ 2018-10-05 16:11 Arnd Bergmann
2018-10-05 18:10 ` Santosh Shilimkar
2018-10-08 2:53 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-10-05 16:11 UTC (permalink / raw)
To: Santosh Shilimkar, Michael Turquette, Stephen Boyd
Cc: Arnd Bergmann, Rob Herring, linux-kernel, linux-clk
A randconfig build showed that two clk modules have no license tag:
WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/gate.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/pll.o
see include/linux/module.h for more information
Add the appropriate information from the comment at the start of the
two files.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I had not seen this until today, no idea why it showed up now on arm64.
---
drivers/clk/keystone/gate.c | 5 +++++
drivers/clk/keystone/pll.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/drivers/clk/keystone/gate.c b/drivers/clk/keystone/gate.c
index def15db4eef0..4ed9b29ba438 100644
--- a/drivers/clk/keystone/gate.c
+++ b/drivers/clk/keystone/gate.c
@@ -266,3 +266,8 @@ static void __init of_keystone_psc_clk_init(struct device_node *node)
}
CLK_OF_DECLARE(keystone_gate_clk, "ti,keystone,psc-clock",
of_keystone_psc_clk_init);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Clock driver for Keystone 2 based devices");
+MODULE_AUTHOR("Murali Karicheri <m-karicheri2@ti.com>");
+MODULE_AUTHOR("Santosh Shilimkar <santosh.shilimkar@ti.com>");
diff --git a/drivers/clk/keystone/pll.c b/drivers/clk/keystone/pll.c
index 2b871fc91d56..349540469fc0 100644
--- a/drivers/clk/keystone/pll.c
+++ b/drivers/clk/keystone/pll.c
@@ -338,3 +338,8 @@ static void __init of_pll_mux_clk_init(struct device_node *node)
pr_err("%s: error registering mux %s\n", __func__, clk_name);
}
CLK_OF_DECLARE(pll_mux_clock, "ti,keystone,pll-mux-clock", of_pll_mux_clk_init);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("PLL clock driver for Keystone devices");
+MODULE_AUTHOR("Murali Karicheri <m-karicheri2@ti.com>");
+MODULE_AUTHOR("Santosh Shilimkar <santosh.shilimkar@ti.com>");
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: keystone: add missing MODULE_LICENSE
2018-10-05 16:11 [PATCH] clk: keystone: add missing MODULE_LICENSE Arnd Bergmann
@ 2018-10-05 18:10 ` Santosh Shilimkar
2018-10-08 2:53 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Santosh Shilimkar @ 2018-10-05 18:10 UTC (permalink / raw)
To: Arnd Bergmann, Stephen Boyd
Cc: Santosh Shilimkar, Michael Turquette, Rob Herring, linux-kernel,
linux-clk
On 10/5/2018 9:11 AM, Arnd Bergmann wrote:
> A randconfig build showed that two clk modules have no license tag:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/gate.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/pll.o
> see include/linux/module.h for more information
>
> Add the appropriate information from the comment at the start of the
> two files.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks Arnd.
Acked-by: Santosh Shilimkar <ssantosh@krenel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: keystone: add missing MODULE_LICENSE
2018-10-05 16:11 [PATCH] clk: keystone: add missing MODULE_LICENSE Arnd Bergmann
2018-10-05 18:10 ` Santosh Shilimkar
@ 2018-10-08 2:53 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-10-08 2:53 UTC (permalink / raw)
To: Arnd Bergmann, Michael Turquette, Santosh Shilimkar
Cc: Arnd Bergmann, Rob Herring, linux-kernel, linux-clk
Quoting Arnd Bergmann (2018-10-05 09:11:15)
> A randconfig build showed that two clk modules have no license tag:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/gate.o
> see include/linux/module.h for more information
> WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/keystone/pll.o
> see include/linux/module.h for more information
>
> Add the appropriate information from the comment at the start of the
> two files.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-08 2:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 16:11 [PATCH] clk: keystone: add missing MODULE_LICENSE Arnd Bergmann
2018-10-05 18:10 ` Santosh Shilimkar
2018-10-08 2:53 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).