linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Christoph Hellwig <hch@lst.de>, Robin Murphy <robin.murphy@arm.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2] dma-debug: Check for drivers mapping invalid addresses in dma_map_single()
Date: Sun, 07 Oct 2018 21:32:30 -0700	[thread overview]
Message-ID: <153897315026.119890.9913725764215566223@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <62816605-0cc9-3743-e98c-682bf7996c6c@arm.com>

Quoting Robin Murphy (2018-10-02 07:01:42)
> On 01/10/18 22:53, Stephen Boyd wrote:
> > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> > index d23fc45c8208..99ccba66c06a 100644
> > --- a/include/linux/dma-mapping.h
> > +++ b/include/linux/dma-mapping.h
> > @@ -231,6 +231,7 @@ static inline dma_addr_t dma_map_single_attrs(struct device *dev, void *ptr,
> >       dma_addr_t addr;
> >   
> >       BUG_ON(!valid_dma_direction(dir));
> > +     debug_dma_check_single(dev, ptr, size);
> 
> Ahem...
> 
> With that (and below) fixed so that it actually compiles,
> 
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>

Thanks for checking! ;)


  reply	other threads:[~2018-10-08  4:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 21:53 [PATCH v2] dma-debug: Check for drivers mapping invalid addresses in dma_map_single() Stephen Boyd
2018-10-02 14:01 ` Robin Murphy
2018-10-08  4:32   ` Stephen Boyd [this message]
2018-10-08  6:36     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153897315026.119890.9913725764215566223@swboyd.mtv.corp.google.com \
    --to=swboyd@chromium.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).