linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Lee Jones <lee.jones@linaro.org>,
	Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Douglas Anderson <dianders@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning
Date: Tue, 09 Oct 2018 09:15:53 -0700	[thread overview]
Message-ID: <153910175330.119890.2963290473787316949@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20180928011614.GA3681@flashbox>

Quoting Nathan Chancellor (2018-09-27 18:16:14)
> On Wed, Sep 26, 2018 at 08:33:17PM -0700, Nathan Chancellor wrote:
> > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > index 999dac752bcc..8f9d6964173e 100644
> > --- a/drivers/mfd/cros_ec_dev.c
> > +++ b/drivers/mfd/cros_ec_dev.c
> > @@ -546,6 +546,7 @@ static struct platform_driver cros_ec_dev_driver = {
> >               .name = DRV_NAME,
> >               .pm = &cros_ec_dev_pm_ops,
> >       },
> > +     .id_table = cros_ec_id,
> >       .probe = ec_device_probe,
> >       .remove = ec_device_remove,
> >       .shutdown = ec_device_shutdown,
> > -- 
> > 2.19.0
> > 
> 
> It just occurred to me I probably should have added some of the Chromium
> guys who have modified this driver to this patch. I've done that now.

Looks OK to me.

Acked-by: Stephen Boyd <swboyd@chromium.org>


      parent reply	other threads:[~2018-10-09 16:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  3:33 [PATCH] mfd: cros_ec: Avoid unneeded internal declaration warning Nathan Chancellor
2018-09-28  1:16 ` Nathan Chancellor
2018-10-09 10:09   ` Lee Jones
2018-10-09 16:15   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153910175330.119890.2963290473787316949@swboyd.mtv.corp.google.com \
    --to=swboyd@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dianders@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).