From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF2BC71122 for ; Fri, 12 Oct 2018 19:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86D9021480 for ; Fri, 12 Oct 2018 19:50:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="w20WtD8t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86D9021480 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbeJMDYs (ORCPT ); Fri, 12 Oct 2018 23:24:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:33218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbeJMDYs (ORCPT ); Fri, 12 Oct 2018 23:24:48 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E6D7205F4; Fri, 12 Oct 2018 19:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539373843; bh=c+e22TZjW+fq1w0G8vbx+++DzQT5oxmxvPoskMW39+0=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=w20WtD8too5yZKyAPG3bjczddGOB5Ak2vA677TTZYng1gm8iTuDacFTja86E40RL9 hoUcpRExTyuhJ5RfeexvJpWti+KT4o5RCPSX4UcbkfHLoDSXTBk9TXu1ZKfh4EGf1S F73zXuKxP8tx4G/in76fazFlMhPL3PH8LL+oOipo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Alexandre Belloni From: Stephen Boyd In-Reply-To: <20181012184017.GH2843@piout.net> Cc: devicetree@vger.kernel.org, Michael Turquette , linux-kernel@vger.kernel.org, Rob Herring , Thomas Petazzoni , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20180717222757.10253-1-alexandre.belloni@bootlin.com> <153271100280.48062.2538655794734424353@swboyd.mtv.corp.google.com> <20180816114755.GH21707@piout.net> <153573753043.93865.2420370848457480370@swboyd.mtv.corp.google.com> <153936888640.5275.18223880548754104359@swboyd.mtv.corp.google.com> <20181012184017.GH2843@piout.net> Message-ID: <153937384305.5275.9319960324791639711@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH 00/16] clk: at91: Rework DT bindings Date: Fri, 12 Oct 2018 12:50:43 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Alexandre Belloni (2018-10-12 11:40:17) > On 12/10/2018 11:28:06-0700, Stephen Boyd wrote: > > Quoting Stephen Boyd (2018-08-31 10:45:30) > > > Quoting Alexandre Belloni (2018-08-16 04:47:55) > > > > On 27/07/2018 10:03:22-0700, Stephen Boyd wrote: > > > > > Quoting Alexandre Belloni (2018-07-17 15:27:41) > > > > > > This is the promised rework of the at91 PMC clocks driver. It i= s mainly > > > > > > necessary to remove the DTC warnings but it also complies with = the CCF > > > > > > rule that there should be one node per controller instead of on= e node > > > > > > per clock. > > > > > > = > > > > > > This only handles the PMC, I'm planning to also rework the SCKC= bindings > > > > > > later (without breaking the DT ABI). > > > > > > = > > > > > > The series is based on top of clk-next plus at91-dt so I don't = think it > > > > > > is convenient to have it this cycle. However, I would really li= ke to > > > > > > ensure we agree on the new bindings this cycle before convertin= g all the > > > > > > other platforms as this is a bit tedious. > > > > > > = > > > > > > The first two patches are actually fixes and may be considered = for this > > > > > > cycle. > > > > > > = > > > > > > One nice note: > > > > > > at91-sama5d2_xplained.dtb goes from 29351 bytes to 22082 bytes > > > > > = > > > > > Patches look mostly good. Rob is happy with the bindings and so a= m I. > > > > > = > > > > > One general question is why the drivers can't be moved to real pl= atform > > > > > drivers instead of using OF_CLK_DECLARE? > > > > > = > > > > = > > > > I tried, this makes the clocksource drivers fail with -EPROBE_DEFER= and > > > > so the kernel just stops there. > > > > = > > > = > > > Ok. We have CLK_OF_DECLARE_DRIVER for that. Can you use that? > > > = > > = > > I assume this will be resent. I haven't seen anything yet though. > > = > = > It will, would you be willing to take it for this cycle if I manage to > send it on Monday? (it seems that we will have an -rc8). > = Well there are fixes to be made, so go at your own pace and don't stress yourself to deliver it on Monday. I plan to stop picking most things early next week.