linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Shawn Guo <shawnguo@kernel.org>, Vabhav Sharma <vabhav.sharma@nxp.com>
Cc: "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
	"oss@buserror.net" <oss@buserror.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel-owner@vger.kernel.org" 
	<linux-kernel-owner@vger.kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
	"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
	Leo Li <leoyang.li@nxp.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	Varun Sethi <V.Sethi@nxp.com>, Udit Kumar <udit.kumar@nxp.com>,
	Pankaj Bansal <pankaj.bansal@nxp.com>,
	Ramneek Mehresh <ramneek.mehresh@nxp.com>,
	Ying Zhang <ying.zhang22455@nxp.com>,
	Nipun Gupta <nipun.gupta@nxp.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	Sriram Dash <sriram.dash@nxp.com>
Subject: RE: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support
Date: Mon, 15 Oct 2018 09:48:33 -0700	[thread overview]
Message-ID: <153962211360.5275.18031876744546062419@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <VI1PR04MB4800C0AB214B258793AF9ABAF3FD0@VI1PR04MB4800.eurprd04.prod.outlook.com>

Quoting Vabhav Sharma (2018-10-14 19:58:15)
> > > +
> > > +   pmu {
> > > +           compatible = "arm,cortex-a72-pmu";
> > > +           interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> > > +   };
> > > +
> > > +   psci {
> > > +           compatible = "arm,psci-0.2";
> > > +           method = "smc";
> > > +   };
> > > +
> > > +   memory@80000000 {
> > > +           // DRAM space - 1, size : 2 GB DRAM
> > > +           device_type = "memory";
> > > +           reg = <0x00000000 0x80000000 0 0x80000000>;
> > > +   };
> > > +
> > > +   ddr1: memory-controller@1080000 {
> > > +           compatible = "fsl,qoriq-memory-controller";
> > > +           reg = <0x0 0x1080000 0x0 0x1000>;
> > > +           interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> > > +           little-endian;
> > > +   };
> > > +
> > > +   ddr2: memory-controller@1090000 {
> > > +           compatible = "fsl,qoriq-memory-controller";
> > > +           reg = <0x0 0x1090000 0x0 0x1000>;
> > > +           interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> > > +           little-endian;
> > > +   };
> > > +
> > > +   sysclk: sysclk {
> > 
> > Name the node a bit generic like clock-xxx.
> There is only one clock-unit, Bootloader(U-boot) require sysclk node during device tree fix-up as different platform support varied platform frequency as per reset configuration word used.
> Referred other ARM based platform with one clock using name as x: x

Please add a comment above this node with this information. Newcomers
reading this DTS file won't have any idea why this node is specially
named and a comment will help tremendously here.


  reply	other threads:[~2018-10-15 16:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04  1:03 [PATCH v4 0/6] arm64: dts: NXP: add basic dts file for LX2160A SoC Vabhav Sharma
2018-10-04  1:03 ` [PATCH v4 1/6] dt-bindings: arm64: add compatible for LX2160A Vabhav Sharma
2018-10-04  1:03 ` [PATCH v4 2/6] soc/fsl/guts: Add compatible string " Vabhav Sharma
2018-10-04  1:03 ` [PATCH v4 3/6] clk: qoriq: increase array size of cmux_to_group Vabhav Sharma
2018-10-04  1:03 ` [PATCH v4 4/6] clk: qoriq: Add clockgen support for lx2160a Vabhav Sharma
2018-10-04  1:03 ` [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support Vabhav Sharma
2018-10-08  5:45   ` Shawn Guo
2018-10-15  2:58     ` Vabhav Sharma
2018-10-15 16:48       ` Stephen Boyd [this message]
2018-10-25  4:19         ` Vabhav Sharma
2018-10-04  1:03 ` [PATCH v4 6/6] arm64: dts: add LX2160ARDB board support Vabhav Sharma
2018-10-08  5:52   ` Shawn Guo
2018-10-15  2:44     ` Vabhav Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153962211360.5275.18031876744546062419@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=V.Sethi@nxp.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=nipun.gupta@nxp.com \
    --cc=oss@buserror.net \
    --cc=pankaj.bansal@nxp.com \
    --cc=priyanka.jain@nxp.com \
    --cc=ramneek.mehresh@nxp.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=sriram.dash@nxp.com \
    --cc=sudeep.holla@arm.com \
    --cc=udit.kumar@nxp.com \
    --cc=vabhav.sharma@nxp.com \
    --cc=viresh.kumar@linaro.org \
    --cc=will.deacon@arm.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=ying.zhang22455@nxp.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).