From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18277C5ACCC for ; Tue, 16 Oct 2018 22:24:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8A3B2148E for ; Tue, 16 Oct 2018 22:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xa8xzeYz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8A3B2148E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727095AbeJQGRH (ORCPT ); Wed, 17 Oct 2018 02:17:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:38142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbeJQGRG (ORCPT ); Wed, 17 Oct 2018 02:17:06 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68B4721470; Tue, 16 Oct 2018 22:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539728676; bh=DIQqKEfWzq+vLCL5dz9UEHx2yA6vrrlk9nyXWyd8c6g=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=xa8xzeYzJNojPExghpdsNxwS/0XEeqagfwl3N9lw4jiIp3h+zixiYzY54TwSXmO9b eHlSL7rngK95DzIzWVdOcgssRObNlKzvNNUt5VtGEEkMQ2SItX2SfgCxKPAp9iPe2v B6ipkcih+vyIyk9Vasg3JrPxMjQwN4kcv9lswRbk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Anson Huang , Fabio Estevam , Jerome Forissier , Peng Fan , Rob Herring From: Stephen Boyd In-Reply-To: Cc: dl-linux-imx References: <1533703167-26583-1-git-send-email-Anson.Huang@nxp.com> <153573827629.93865.6200966443862432044@swboyd.mtv.corp.google.com> <153898445180.119890.15025812558797341532@swboyd.mtv.corp.google.com> <153937368201.5275.2313781259297807972@swboyd.mtv.corp.google.com> <153962195779.5275.17500455384946496344@swboyd.mtv.corp.google.com> Message-ID: <153972867573.5275.6495417473527509224@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: RE: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array Date: Tue, 16 Oct 2018 15:24:35 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anson Huang (2018-10-15 21:37:31) > Hi, Stephen > = > Anson Huang > Best Regards! > = > = > > -----Original Message----- > > From: Stephen Boyd > > Sent: Tuesday, October 16, 2018 12:46 AM > > To: kernel@pengutronix.de; linux-arm-kernel@lists.infradead.org; > > linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; > > mturquette@baylibre.com; s.hauer@pengutronix.de; shawnguo@kernel.org; > > Anson Huang ; Fabio Estevam > > ; Jerome Forissier ; > > Peng Fan ; Rob Herring > > Cc: dl-linux-imx > > Subject: RE: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array > > = > > Quoting Anson Huang (2018-10-15 02:33:35) > > > > > > > > > > > > > > > > > > > Why can't we add clks to the op-tee node in DT's /firmware cont= ainer? > > > > > > Then any clks in there can be turned on forever and left enabled > > > > > > by the linux driver? > > > > > > > > > > I did NOT run op-tee with Linux-next kernel before, can you advis= e more? > > > > > > > > Neither have I, so I can't advise more. > > > > > > > > > And I think if op-tee has such requirement, can we have another > > > > > patch to cover it? > > > > > > > > Yes. > > > > > > > > > > > > > I believe all other i.MX platforms also have same requirements if > > > > > considering op-tee support, so I think it should be another topic, > > > > > what do you > > > > think? > > > > > > > > > > > > > I'm going to drop these patches from my review queue. Please resend > > > > them and please include the op-tee patches too. > > > > > > > > > I do NOT know how to include the op-tee patch to meet special > > > requirement, should the op-tee related patch be added later when some= one > > actually add the op-tee support for i.MX7? > > > It should NOT block this patch set, do you think we can add this patc= h set > > first? > > > > > = > > Please resend the two patches. In the commit text for the second patch, > > describe the plan to remove CLK_IS_CRITICAL from these clks by adding an > > OP-TEE device/driver to the kernel to keep these clks enabled. My > > understanding is that there isn't an OP-TEE driver right now, but these= clks are > > used by the firmware and can't be turned off in Linux. If in the future= we want > > to be able to turn them on and off, we'll need to add them to an OP-TEE= device > > node and have that driver manage the clks. > > = > > How that will work when a system doesn't enable the OP-TEE driver I'm n= ot > > sure. We may need to develop some system whereby clks like this are han= ded > > from the clk controller to the consumer driver when it's enabled for fu= rther > > power managment, but if they're never handed off, they're kept on forev= er like > > is done here. Anyway, please resend with a note about why these are mar= ked > > CLK_IS_CRITICAL. > = > I think there is some misunderstanding here, this patch sets those critic= al clocks > with CLK_IS_CRITICAL flag to let clock driver keep them always ON, as the= y are > critical clocks and system (Linux kernel, NOT include op-tee) can NOT run= normally > if anyone of them is OFF. Ok it sounds like OP-TEE usage completely orthogonal here? I'll go apply these refactorings then.