From: Philipp Zabel <p.zabel@pengutronix.de>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
Alexey Brodkin <alexey.brodkin@synopsys.com>
Subject: Re: [PATCH v3] ARC: HSDK: improve reset driver
Date: Wed, 17 Oct 2018 16:25:21 +0200 [thread overview]
Message-ID: <1539786321.4729.8.camel@pengutronix.de> (raw)
In-Reply-To: <20181017140552.7331-1-Eugeniy.Paltsev@synopsys.com>
On Wed, 2018-10-17 at 17:05 +0300, Eugeniy Paltsev wrote:
> As for today HSDK reset driver implements only .reset() callback.
>
> In case of driver which implements one of standard
> reset controller usage pattern
> (call *_deassert() in probe(), call *_assert() in remove())
> that leads to inoperability of this reset driver.
>
> Improve HSDK reset driver by calling .reset() callback inside of
> .deassert() callback to avoid each reset controller
> user adaptation for work with both reset methods
> (reset() and {.assert() & .deassert()} pair)
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> Changes v2->v3:
> * Drop dummy .assert callback.
>
> drivers/reset/reset-hsdk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/reset/reset-hsdk.c b/drivers/reset/reset-hsdk.c
> index 8bce391c6943..4c7b8647b49c 100644
> --- a/drivers/reset/reset-hsdk.c
> +++ b/drivers/reset/reset-hsdk.c
> @@ -86,6 +86,7 @@ static int hsdk_reset_reset(struct reset_controller_dev *rcdev,
>
> static const struct reset_control_ops hsdk_reset_ops = {
> .reset = hsdk_reset_reset,
> + .deassert = hsdk_reset_reset,
> };
>
> static int hsdk_reset_probe(struct platform_device *pdev)
Thank you, applied to reset/next
regards
Philipp
prev parent reply other threads:[~2018-10-17 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 14:05 [PATCH v3] ARC: HSDK: improve reset driver Eugeniy Paltsev
2018-10-17 14:25 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539786321.4729.8.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=alexey.brodkin@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).