linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits
@ 2018-10-23  1:07 Ryan Case
  2018-10-23  9:00 ` Stephen Boyd
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ryan Case @ 2018-10-23  1:07 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-arm-msm, Doug Anderson, Stephen Boyd, Ryan Case,
	linux-kernel, linux-spi

Address remaining comments from original driver patch series

* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment

Signed-off-by: Ryan Case <ryandcase@chromium.org>
---

 drivers/spi/spi-qcom-qspi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
index b8163b40bb92..e0f061139c8f 100644
--- a/drivers/spi/spi-qcom-qspi.c
+++ b/drivers/spi/spi-qcom-qspi.c
@@ -90,6 +90,9 @@
 #define PIO_DATAOUT_1B		0x0020
 #define PIO_DATAOUT_4B		0x0024
 
+#define RD_FIFO_CFG		0x0028
+#define CONTINUOUS_MODE		BIT(0)
+
 #define RD_FIFO_STATUS	0x002c
 #define FIFO_EMPTY	BIT(11)
 #define WR_CNTS_MSK	0x7f0
@@ -99,9 +102,6 @@
 #define RDY_16BYTE	BIT(1)
 #define FIFO_RDY	BIT(0)
 
-#define RD_FIFO_CFG		0x0028
-#define CONTINUOUS_MODE		BIT(0)
-
 #define RD_FIFO_RESET		0x0030
 #define RESET_FIFO		BIT(0)
 
@@ -139,7 +139,7 @@ struct qcom_qspi {
 	struct device *dev;
 	struct clk_bulk_data clks[QSPI_NUM_CLKS];
 	struct qspi_xfer xfer;
-	/* Lock to protect data accessed by IRQs */
+	/* Lock to protect xfer and IRQ accessed registers */
 	spinlock_t lock;
 };
 
-- 
2.19.1.568.g152ad8e336-goog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits
  2018-10-23  1:07 [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits Ryan Case
@ 2018-10-23  9:00 ` Stephen Boyd
  2018-10-23 19:53 ` Doug Anderson
  2018-11-05 18:29 ` Doug Anderson
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2018-10-23  9:00 UTC (permalink / raw)
  To: Mark Brown, Ryan Case
  Cc: linux-arm-msm, Doug Anderson, Ryan Case, linux-kernel, linux-spi

Quoting Ryan Case (2018-10-22 18:07:07)
> Address remaining comments from original driver patch series
> 
> * Move RD_FIFO_CFG to be ordered corretly
> * Expand spinlock comment
> 
> Signed-off-by: Ryan Case <ryandcase@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits
  2018-10-23  1:07 [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits Ryan Case
  2018-10-23  9:00 ` Stephen Boyd
@ 2018-10-23 19:53 ` Doug Anderson
  2018-11-05 18:29 ` Doug Anderson
  2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2018-10-23 19:53 UTC (permalink / raw)
  To: ryandcase; +Cc: Mark Brown, linux-arm-msm, Stephen Boyd, LKML, linux-spi

Hi,
On Mon, Oct 22, 2018 at 6:07 PM Ryan Case <ryandcase@chromium.org> wrote:
>
> Address remaining comments from original driver patch series
>
> * Move RD_FIFO_CFG to be ordered corretly
> * Expand spinlock comment
>
> Signed-off-by: Ryan Case <ryandcase@chromium.org>
> ---
>
>  drivers/spi/spi-qcom-qspi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits
  2018-10-23  1:07 [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits Ryan Case
  2018-10-23  9:00 ` Stephen Boyd
  2018-10-23 19:53 ` Doug Anderson
@ 2018-11-05 18:29 ` Doug Anderson
  2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2018-11-05 18:29 UTC (permalink / raw)
  To: ryandcase, Mark Brown; +Cc: linux-arm-msm, Stephen Boyd, LKML, linux-spi

Mark,

On Mon, Oct 22, 2018 at 6:07 PM Ryan Case <ryandcase@chromium.org> wrote:
>
> Address remaining comments from original driver patch series
>
> * Move RD_FIFO_CFG to be ordered corretly
> * Expand spinlock comment
>
> Signed-off-by: Ryan Case <ryandcase@chromium.org>
> ---
>
>  drivers/spi/spi-qcom-qspi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

No huge deal (obviously) but I noticed that you landed a batch of
similar patches last night but didn't land this one.  Did it fall off
your radar or is there some other reason not to land it?

Thanks!

-Doug

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-05 18:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23  1:07 [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits Ryan Case
2018-10-23  9:00 ` Stephen Boyd
2018-10-23 19:53 ` Doug Anderson
2018-11-05 18:29 ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).