From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3458FC46475 for ; Tue, 23 Oct 2018 21:32:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8E462081B for ; Tue, 23 Oct 2018 21:32:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="I0ss6mK8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8E462081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728909AbeJXF5V (ORCPT ); Wed, 24 Oct 2018 01:57:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:33138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbeJXF5V (ORCPT ); Wed, 24 Oct 2018 01:57:21 -0400 Received: from tzanussi-mobl (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13FA42075D; Tue, 23 Oct 2018 21:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540330329; bh=Skrjn3QssIqMENFd9hn+S1HnPTGSTDG7Qh2beAcbPf8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=I0ss6mK8cN1ilb8HjS51ZQPKaJzTy6Jqb56Kb/0cmJbuWrvrr7vsxbyh7FDCGk799 oQJIBCyHZ9so/nHArgbaZrNRBMSeSmlO8D7UVGQJ/Dr1MtHtXSOGs0kDoe3KDs67O9 1M1W/lOjBwO/89SAxtLc6XuhwA+zrHiun+SKb5nc= Message-ID: <1540330327.6502.13.camel@kernel.org> Subject: Re: [PATCH v6 10/15] tracing: Add hist trigger snapshot() action test case From: Tom Zanussi To: Masami Hiramatsu Cc: rostedt@goodmis.org, tglx@linutronix.de, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, julia@ni.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Date: Tue, 23 Oct 2018 16:32:07 -0500 In-Reply-To: <20181024000342.d1e82a160a5efecdb9c0d4f5@kernel.org> References: <75db4ded21471580e5ad8d57c74fd9c8923cd90a.1539288364.git.tom.zanussi@linux.intel.com> <20181024000342.d1e82a160a5efecdb9c0d4f5@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masami, On Wed, 2018-10-24 at 00:03 +0900, Masami Hiramatsu wrote: > On Thu, 11 Oct 2018 16:02:07 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Add a test case verifying the basic functionality of the > > hist:snapshot() action. > > > > I think this is OK for current tracing tree, but for next kernel > version > you may need to update it (against the kselftest tree) > OK. > > Signed-off-by: Tom Zanussi > > --- > > .../inter-event/trigger-snapshot-action-hist.tc | 55 > > ++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > create mode 100644 > > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger- > > snapshot-action-hist.tc > > > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter- > > event/trigger-snapshot-action-hist.tc > > b/tools/testing/selftests/ftrace/test.d/trigger/inter- > > event/trigger-snapshot-action-hist.tc > > new file mode 100644 > > index 000000000000..f427be989296 > > --- /dev/null > > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter- > > event/trigger-snapshot-action-hist.tc > > @@ -0,0 +1,55 @@ > > +#!/bin/sh > > +# description: event trigger - test inter-event histogram trigger > > snapshot action > > + > > +do_reset() { > > + reset_trigger > > + echo > set_event > > + echo 0 > snapshot > > + clear_trace > > +} > > + > > +fail() { #msg > > + do_reset > > + echo $1 > > + exit_fail > > +} > > + > > +if [ ! -f set_event ]; then > > + echo "event tracing is not supported" > > + exit_unsupported > > +fi > > + > > +if [ ! -f snapshot ]; then > > + echo "snapshot is not supported" > > + exit_unsupported > > +fi > > + > > +grep "onchange(var)" README > /dev/null || exit_unsupported # > > version issue > > grep -q will be better. > > > + > > +grep "snapshot()" README > /dev/null || exit_unsupported # version > > issue > > Ditto. > > > + > > +reset_tracer > > +do_reset > > Depends on the merge timing, but I already moved this kind of "reset > before/after test" into initialize_ftrace(), so you don't need > do_reset() > here. It is required only if you reset tracer in between tests. > OK, good to know, thanks. At this point it probably will be the next kernel version, so will make all the suggested changes for that version. > > + > > +echo "Test snapshot action" > > + > > +echo 1 > /sys/kernel/debug/tracing/events/sched/enable > > + > > +echo > > 'hist:keys=comm:newprio=prio:onchange($newprio).save(comm,prio):onc > > hange($newprio).snapshot() if comm=="ping"' >> > > /sys/kernel/debug/tracing/events/sched/sched_waking/trigger > > + > > +ping localhost -c 3 > > +nice -n 1 ping localhost -c 3 > > Ditto. please use $LOCALHOST if you send this to the latest tree. > > http://lkml.kernel.org/r/153563862993.29700.6436770573173736555.stgit > @devbox > OK, thanks for pointing that out. > > + > > +echo 0 > /sys/kernel/debug/tracing/events/sched/enable > > + > > +if ! grep -q "changed:" events/sched/sched_waking/hist; then > > + fail "Failed to create onchange action inter-event histogram" > > +fi > > + > > +if ! grep -q "comm=ping" snapshot; then > > + fail "Failed to create snapshot action inter-event histogram" > > +fi > > + > > +do_reset > > Also you don't need this. > > > BTW, are there no "expected fail" tests? (e.g. passing wrong snapshot > command to trigger) > Good point, will add an expected fail for snapshot and not onmax/onchange. Thanks, Tom > Thank you, > > > + > > +exit 0 > > -- > > 2.14.1 > > > >