linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] f2fs: only flush the single temp bio cache which owns the target page
@ 2018-10-24  8:10 Yunlong Song
  2018-10-24  9:55 ` Chao Yu
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Yunlong Song @ 2018-10-24  8:10 UTC (permalink / raw)
  To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
  Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
	linux-kernel

Previously, when f2fs finds which temp bio cache owns the target page,
it will flush all the three temp bio caches, but we only need to flush
one single bio cache indeed, which can help to keep bio merged.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
 fs/f2fs/data.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 106f116..04ebbad 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -374,7 +374,7 @@ static bool __has_merged_page(struct f2fs_bio_info *io, struct inode *inode,
 
 static bool has_merged_page(struct f2fs_sb_info *sbi, struct inode *inode,
 						struct page *page, nid_t ino,
-						enum page_type type)
+						enum page_type type, enum temp_type *owner)
 {
 	enum page_type btype = PAGE_TYPE_OF_BIO(type);
 	enum temp_type temp;
@@ -392,6 +392,10 @@ static bool has_merged_page(struct f2fs_sb_info *sbi, struct inode *inode,
 		if (ret || btype == META)
 			break;
 	}
+	if (!ret || (!inode && !page && !ino))
+		*owner = NR_TEMP_TYPE;
+	else
+		*owner = temp;
 	return ret;
 }
 
@@ -421,9 +425,14 @@ static void __submit_merged_write_cond(struct f2fs_sb_info *sbi,
 {
 	enum temp_type temp;
 
-	if (!force && !has_merged_page(sbi, inode, page, ino, type))
+	if (!force && !has_merged_page(sbi, inode, page, ino, type, &temp))
 		return;
 
+	if (!force && temp != NR_TEMP_TYPE) {
+		__f2fs_submit_merged_write(sbi, type, temp);
+		return;
+	}
+
 	for (temp = HOT; temp < NR_TEMP_TYPE; temp++) {
 
 		__f2fs_submit_merged_write(sbi, type, temp);
-- 
1.8.5.2


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-11-14 10:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24  8:10 [PATCH] f2fs: only flush the single temp bio cache which owns the target page Yunlong Song
2018-10-24  9:55 ` Chao Yu
2018-10-24 11:35 ` [PATCH v2] " Yunlong Song
2018-10-25  1:35   ` Chao Yu
2018-11-13  0:15   ` Jaegeuk Kim
2018-11-13  3:57 ` [PATCH v3] " Yunlong Song
2018-11-14 10:49   ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).