linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] f2fs: change segment to section in f2fs_ioc_gc_range
@ 2018-10-24 14:35 Yunlong Song
  2018-10-25  1:46 ` Chao Yu
  2018-10-30 12:37 ` [PATCH v2] " Yunlong Song
  0 siblings, 2 replies; 4+ messages in thread
From: Yunlong Song @ 2018-10-24 14:35 UTC (permalink / raw)
  To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
  Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
	linux-kernel

f2fs_ioc_gc_range skips blocks_per_seg each time, however, f2fs_gc moves
blocks of section each time, so fix it from segment to section.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
 fs/f2fs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 88b1246..8c06724 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2155,7 +2155,7 @@ static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg)
 	}
 
 	ret = f2fs_gc(sbi, range.sync, true, GET_SEGNO(sbi, range.start));
-	range.start += sbi->blocks_per_seg;
+	range.start += sbi->blocks_per_seg * sbi->segs_per_sec;
 	if (range.start <= end)
 		goto do_more;
 out:
-- 
1.8.5.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] f2fs: change segment to section in f2fs_ioc_gc_range
  2018-10-24 14:35 [PATCH] f2fs: change segment to section in f2fs_ioc_gc_range Yunlong Song
@ 2018-10-25  1:46 ` Chao Yu
  2018-10-30 12:37 ` [PATCH v2] " Yunlong Song
  1 sibling, 0 replies; 4+ messages in thread
From: Chao Yu @ 2018-10-25  1:46 UTC (permalink / raw)
  To: Yunlong Song, jaegeuk, chao, yunlong.song
  Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
	linux-kernel

On 2018/10/24 22:35, Yunlong Song wrote:
> f2fs_ioc_gc_range skips blocks_per_seg each time, however, f2fs_gc moves
> blocks of section each time, so fix it from segment to section.

I'm okay with this change, BTW, I notice that I need to change it to use
sbi->blocks_per_seg * sbi->migration_granularity in my patchset if this
patch being merged firstly.

> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>  fs/f2fs/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 88b1246..8c06724 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2155,7 +2155,7 @@ static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg)
>  	}
>  
>  	ret = f2fs_gc(sbi, range.sync, true, GET_SEGNO(sbi, range.start));
> -	range.start += sbi->blocks_per_seg;
> +	range.start += sbi->blocks_per_seg * sbi->segs_per_sec;

use BLKS_PER_SEC() for cleanup?

>  	if (range.start <= end)
>  		goto do_more;
>  out:
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] f2fs: change segment to section in f2fs_ioc_gc_range
  2018-10-24 14:35 [PATCH] f2fs: change segment to section in f2fs_ioc_gc_range Yunlong Song
  2018-10-25  1:46 ` Chao Yu
@ 2018-10-30 12:37 ` Yunlong Song
  2018-10-31  3:32   ` Chao Yu
  1 sibling, 1 reply; 4+ messages in thread
From: Yunlong Song @ 2018-10-30 12:37 UTC (permalink / raw)
  To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
  Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
	linux-kernel

f2fs_ioc_gc_range skips blocks_per_seg each time, however, f2fs_gc moves
blocks of section each time, so fix it from segment to section.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
 fs/f2fs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 88b1246..f981b6c 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2155,7 +2155,7 @@ static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg)
 	}
 
 	ret = f2fs_gc(sbi, range.sync, true, GET_SEGNO(sbi, range.start));
-	range.start += sbi->blocks_per_seg;
+	range.start += BLKS_PER_SEC(sbi);
 	if (range.start <= end)
 		goto do_more;
 out:
-- 
1.8.5.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] f2fs: change segment to section in f2fs_ioc_gc_range
  2018-10-30 12:37 ` [PATCH v2] " Yunlong Song
@ 2018-10-31  3:32   ` Chao Yu
  0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2018-10-31  3:32 UTC (permalink / raw)
  To: Yunlong Song, jaegeuk, chao, yunlong.song
  Cc: miaoxie, bintian.wang, shengyong1, heyunlei, linux-f2fs-devel,
	linux-kernel

On 2018/10/30 20:37, Yunlong Song wrote:
> f2fs_ioc_gc_range skips blocks_per_seg each time, however, f2fs_gc moves
> blocks of section each time, so fix it from segment to section.
> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-31  3:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 14:35 [PATCH] f2fs: change segment to section in f2fs_ioc_gc_range Yunlong Song
2018-10-25  1:46 ` Chao Yu
2018-10-30 12:37 ` [PATCH v2] " Yunlong Song
2018-10-31  3:32   ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).