linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi: dw: fix buffer end address
@ 2018-10-24 15:37 Jaewon Kim
  2018-10-29 16:35 ` Jaewon Kim
  0 siblings, 1 reply; 2+ messages in thread
From: Jaewon Kim @ 2018-10-24 15:37 UTC (permalink / raw)
  To: Mark Brown, Jaewon Kim; +Cc: linux-spi, linux-kernel

Buffer address can be NULL, if user does not want to receive TX/RX data.
In this case, driver should not set the rx/tx_end value with len.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
 drivers/spi/spi-dw.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index b705f2b..34e6fca 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -293,9 +293,13 @@ static int dw_spi_transfer_one(struct spi_controller *master,
 	dws->dma_mapped = 0;
 
 	dws->tx = (void *)transfer->tx_buf;
-	dws->tx_end = dws->tx + transfer->len;
+	dws->tx_end = dws->tx;
+	if (dws->tx)
+		dws->tx_end += transfer->len;
 	dws->rx = transfer->rx_buf;
-	dws->rx_end = dws->rx + transfer->len;
+	dws->rx_end = dws->rx;
+	if (dws->rx)
+		dws->rx_end += transfer->len;
 	dws->len = transfer->len;
 
 	spi_enable_chip(dws, 0);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi: dw: fix buffer end address
  2018-10-24 15:37 [PATCH] spi: dw: fix buffer end address Jaewon Kim
@ 2018-10-29 16:35 ` Jaewon Kim
  0 siblings, 0 replies; 2+ messages in thread
From: Jaewon Kim @ 2018-10-29 16:35 UTC (permalink / raw)
  To: Mark Brown, Jaewon Kim; +Cc: linux-spi, linux-kernel

There is some side effect on this patch.

So, I revoke this patch.


18. 10. 25. 오전 12:37에 Jaewon Kim 이(가) 쓴 글:
> Buffer address can be NULL, if user does not want to receive TX/RX data.
> In this case, driver should not set the rx/tx_end value with len.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>   drivers/spi/spi-dw.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
> index b705f2b..34e6fca 100644
> --- a/drivers/spi/spi-dw.c
> +++ b/drivers/spi/spi-dw.c
> @@ -293,9 +293,13 @@ static int dw_spi_transfer_one(struct spi_controller *master,
>   	dws->dma_mapped = 0;
>   
>   	dws->tx = (void *)transfer->tx_buf;
> -	dws->tx_end = dws->tx + transfer->len;
> +	dws->tx_end = dws->tx;
> +	if (dws->tx)
> +		dws->tx_end += transfer->len;
>   	dws->rx = transfer->rx_buf;
> -	dws->rx_end = dws->rx + transfer->len;
> +	dws->rx_end = dws->rx;
> +	if (dws->rx)
> +		dws->rx_end += transfer->len;
>   	dws->len = transfer->len;
>   
>   	spi_enable_chip(dws, 0);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-29 16:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 15:37 [PATCH] spi: dw: fix buffer end address Jaewon Kim
2018-10-29 16:35 ` Jaewon Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).