archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <>
To: Colin King <>,
	Hannes Reinecke <>,
	"Martin K . Petersen" <>,
Subject: Re: [PATCH] scsi: aic7xxx: Fix unintended sign extension issue
Date: Thu, 25 Oct 2018 16:32:49 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote:
> From: Colin Ian King <>
> In the expression "ahc_inb(ahc, port+3) << 24", the initial value is
> a u8, but is promoted to a signed int, then sign-extended to
> uint64_t.

Why is this, that's highly non intuitive?  The compiler is supposed to
promote to the biggest type, which is uint64_t and then do the


  parent reply	other threads:[~2018-10-25 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 15:13 Colin King
2018-10-25 15:32 ` Joe Perches
2018-10-25 15:32 ` James Bottomley [this message]
2018-10-25 15:54   ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] scsi: aic7xxx: Fix unintended sign extension issue' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).