From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35E6C46475 for ; Thu, 25 Oct 2018 15:47:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A081C20854 for ; Thu, 25 Oct 2018 15:47:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A081C20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbeJZAVI (ORCPT ); Thu, 25 Oct 2018 20:21:08 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34839 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727313AbeJZAVH (ORCPT ); Thu, 25 Oct 2018 20:21:07 -0400 Received: by mail-pf1-f193.google.com with SMTP id l17-v6so4401771pff.2 for ; Thu, 25 Oct 2018 08:47:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tzs/NZOK8c5Mx+o7q/S5ja1it3V31h8NO/xpeM+GYCY=; b=W8ul1DIfzXr2gEgaJXQW/RnFeeq0P3d8NCXnK/sgf6YP6yEfbJ0tdT8jIyI0D+2WYi uuS/CVTou4uRr+kG7s0nJhcABWZPLfz9a1VLKjtVI8LpTH8G4CYpG0Ed11M7xHqyv3rs yHgNHOCVpoKnWv+CHN2ZonEgazFyXqLkD7cJMHFIqqG5i40eA94Z6xF/NGiSZaAdGn/t OrIaFzkheUaAZtvSIMtalWjOcx4f4IbY/9mUcpgyLB82gBYhwAPwBh4GvlFZNYZJAMMy X0cMwiKxatwFXmnOBepsLQwOYtMn1w5FZItM0LIUu9pi1utD2MumBmQN+evWA6DiyA5v td0g== X-Gm-Message-State: AGRZ1gIoWDo40x5nBc5RvC9nJurYp2FXPG2I/gApn+P9eyaAf9vg6DRg Bx/fgRikiJIw/RpyIDyHp8Y= X-Google-Smtp-Source: AJdET5c1UwT6Gs1OhZWu7jvPmqQuRsxRgxy5B8QkccacmCeSmQqGnHD93FoAcq4vfd2K7XSdjEnPnQ== X-Received: by 2002:a65:44c6:: with SMTP id g6-v6mr1909485pgs.350.1540482467075; Thu, 25 Oct 2018 08:47:47 -0700 (PDT) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id b16-v6sm4287195pfm.145.2018.10.25.08.47.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Oct 2018 08:47:46 -0700 (PDT) Message-ID: <1540482465.66186.14.camel@acm.org> Subject: Re: [PATCH 0/3] Suppress false positives triggered by workqueue lockdep annotations From: Bart Van Assche To: Johannes Berg , Tejun Heo Cc: "linux-kernel@vger.kernel.org" , Christoph Hellwig , Sagi Grimberg , "tytso@mit.edu" Date: Thu, 25 Oct 2018 08:47:45 -0700 In-Reply-To: <8e7bac982621666375c2f5698e995f443343b3ad.camel@sipsolutions.net> References: <20181025150540.259281-1-bvanassche@acm.org> <8e7bac982621666375c2f5698e995f443343b3ad.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-10-25 at 17:27 +-0200, Johannes Berg wrote: +AD4 +AD4 In my tests with kernel v4.19 I noticed that several new false positive +AD4 +AD4 reports were generated by the workqueue lockdep annotations. This patch +AD4 +AD4 series addresses one of these false positives. +AD4 +AD4 I tried my best to explain why they're not false positives as far as +AD4 lockdep is concerned, so I'd appreciate if you could address +ACo-why+ACo you +AD4 actually think they are such. Please read the descriptions of the individual patches. These descriptions explain clearly which false positives are being addressed. Bart.