linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Rik van Riel <riel@surriel.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>, Wang <wang.yi59@zte.com.cn>,
	zhong.weidong@zte.com.cn, Yi Liu <liu.yi24@zte.com.cn>,
	Frederic Weisbecker <frederic@kernel.org>
Subject: [PATCH v3 0/3] isolcpus
Date: Fri, 26 Oct 2018 00:12:20 +0530	[thread overview]
Message-ID: <1540492943-17147-1-git-send-email-srikar@linux.vnet.ibm.com> (raw)

It looks like cpus_allowed can have a mix of isolcpus and non-isolcpus.
However that seems to cause some inconsistent behaviour esp with numa
balancing.
The first patch will only add a warning whenever a user tries to pass a mask
that has a mix of both isolcpus and nonisolcpus.

The second patch will detect and correct mixed cpumask but silently.
Since set_cpus_allowed_common is under a spinlock, it doesnt add any hints
when it corrects the cpumask.

The third patch returns an error if a user passes a mixed cpumask.  Its an
addition to the first patch. However separating it out helps if ever we have
to revert the earlier behaviour. This might cause a change in
sched_setaffinity behaviour when isolcpus is set.

Srikar Dronamraju (3):
  sched/core: Warn if cpumask has a mix of isolcpus and housekeeping
    CPUs
  sched/core: Don't mix isolcpus and housekeeping CPUs
  sched/core: Error out if cpumask has a mix of isolcpus and
    housekeeping CPUs

 kernel/sched/core.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

-- 
1.8.3.1


             reply	other threads:[~2018-10-25 18:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 18:42 Srikar Dronamraju [this message]
2018-10-25 18:42 ` [PATCH v3 1/3] sched/core: Warn if cpumask has a mix of isolcpus and housekeeping CPUs Srikar Dronamraju
2018-10-26  8:32   ` Peter Zijlstra
2018-10-25 18:42 ` [PATCH v3 2/3] sched/core: Don't mix " Srikar Dronamraju
2018-10-26  8:33   ` Peter Zijlstra
2018-10-25 18:42 ` [PATCH v3 3/3] sched/core: Error out if cpumask has a mix of " Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1540492943-17147-1-git-send-email-srikar@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liu.yi24@zte.com.cn \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    --cc=tglx@linutronix.de \
    --cc=wang.yi59@zte.com.cn \
    --cc=zhong.weidong@zte.com.cn \
    --subject='Re: [PATCH v3 0/3] isolcpus' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).